From bd68d42843551d4819fd94246d3c8233d14ef93b Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Thu, 22 Jul 2010 16:35:00 +0000 Subject: [PATCH] Map MDNode correctly. A non function local MDNode can have an operand which is cloned by MapValue(). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@109117 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Utils/ValueMapper.cpp | 33 +++++++++++++++++++++++----- 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/lib/Transforms/Utils/ValueMapper.cpp b/lib/Transforms/Utils/ValueMapper.cpp index 3f6a90c94eb..1cd5cca9b6e 100644 --- a/lib/Transforms/Utils/ValueMapper.cpp +++ b/lib/Transforms/Utils/ValueMapper.cpp @@ -14,6 +14,7 @@ #include "ValueMapper.h" #include "llvm/Type.h" +#include "llvm/GlobalAlias.h" #include "llvm/Constants.h" #include "llvm/Function.h" #include "llvm/Metadata.h" @@ -29,15 +30,35 @@ Value *llvm::MapValue(const Value *V, ValueToValueMapTy &VM) { // Global values and non-function-local metadata do not need to be seeded into // the VM if they are using the identity mapping. - if (isa(V) || isa(V) || isa(V) || - (isa(V) && !cast(V)->isFunctionLocal())) + if (isa(V) || isa(V) || isa(V)) return VMSlot = const_cast(V); if (const MDNode *MD = dyn_cast(V)) { - SmallVector Elts; - for (unsigned i = 0, e = MD->getNumOperands(); i != e; ++i) - Elts.push_back(MD->getOperand(i) ? MapValue(MD->getOperand(i), VM) : 0); - return VM[V] = MDNode::get(V->getContext(), Elts.data(), Elts.size()); + Value *Dummy = new GlobalAlias(V->getType(), GlobalValue::ExternalLinkage); + VMSlot = Dummy; + for (unsigned i = 0, e = MD->getNumOperands(); i != e; ++i) { + Value *OP = MD->getOperand(i); + if (!OP) continue; + Value *MV = MapValue(OP, VM); + if (MV != OP) { + // This MDNode contain a reference to mapped value. Make a new + // MDNode and return it. + SmallVector Elts; + Elts.reserve(MD->getNumOperands()); + for (unsigned j = 0; j != i; ++j) + Elts.push_back(MD->getOperand(j)); + Elts.push_back(MV); + for (++i; i != e; ++i) + Elts.push_back(MD->getOperand(i) ? + MapValue(MD->getOperand(i), VM) : 0); + MDNode *NewMD = MDNode::get(V->getContext(), Elts.data(), Elts.size()); + Dummy->uncheckedReplaceAllUsesWith(NewMD); + delete Dummy; + return VM[V] = NewMD; + } + } + delete Dummy; + return VM[V] = const_cast(V); } Constant *C = const_cast(dyn_cast(V)); -- 2.34.1