From bab812b4b0126839fe6e026aad54c90164c89765 Mon Sep 17 00:00:00 2001 From: Bob Wilson Date: Thu, 13 Aug 2009 05:58:56 +0000 Subject: [PATCH] Revert r78852 for now. I want to do this differently, but I don't have time to fix it tonight. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@78896 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/ARM/ARMISelLowering.cpp | 3 --- lib/Target/ARM/ARMISelLowering.h | 3 +-- lib/Target/ARM/ARMInstrNEON.td | 35 +++++++++++++++++++----------- 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/lib/Target/ARM/ARMISelLowering.cpp b/lib/Target/ARM/ARMISelLowering.cpp index 785a7ded6d3..2307602f471 100644 --- a/lib/Target/ARM/ARMISelLowering.cpp +++ b/lib/Target/ARM/ARMISelLowering.cpp @@ -487,7 +487,6 @@ const char *ARMTargetLowering::getTargetNodeName(unsigned Opcode) const { case ARMISD::VREV64: return "ARMISD::VREV64"; case ARMISD::VREV32: return "ARMISD::VREV32"; case ARMISD::VREV16: return "ARMISD::VREV16"; - case ARMISD::VSPLAT0: return "ARMISD::VSPLAT0"; } } @@ -2443,8 +2442,6 @@ static SDValue LowerVECTOR_SHUFFLE(SDValue Op, SelectionDAG &DAG) { // DAG nodes, instead of keeping them as shuffles and matching them again // during code selection. This is more efficient and avoids the possibility // of inconsistencies between legalization and selection. - if (SVN->isSplat() && SVN->getSplatIndex() == 0) - return DAG.getNode(ARMISD::VSPLAT0, dl, VT, SVN->getOperand(0)); if (isVREVMask(SVN, 64)) return DAG.getNode(ARMISD::VREV64, dl, VT, SVN->getOperand(0)); if (isVREVMask(SVN, 32)) diff --git a/lib/Target/ARM/ARMISelLowering.h b/lib/Target/ARM/ARMISelLowering.h index 57f3c4d012c..328959a24d9 100644 --- a/lib/Target/ARM/ARMISelLowering.h +++ b/lib/Target/ARM/ARMISelLowering.h @@ -129,8 +129,7 @@ namespace llvm { // Vector shuffles: VREV64, // reverse elements within 64-bit doublewords VREV32, // reverse elements within 32-bit words - VREV16, // reverse elements within 16-bit halfwords - VSPLAT0 // duplicate element 0 into all elements + VREV16 // reverse elements within 16-bit halfwords }; } diff --git a/lib/Target/ARM/ARMInstrNEON.td b/lib/Target/ARM/ARMInstrNEON.td index 38e8800e039..7654be7b3fd 100644 --- a/lib/Target/ARM/ARMInstrNEON.td +++ b/lib/Target/ARM/ARMInstrNEON.td @@ -99,7 +99,6 @@ def SDTARMVSHUF : SDTypeProfile<1, 1, [SDTCisVec<0>, SDTCisSameAs<0, 1>]>; def NEONvrev64 : SDNode<"ARMISD::VREV64", SDTARMVSHUF>; def NEONvrev32 : SDNode<"ARMISD::VREV32", SDTARMVSHUF>; def NEONvrev16 : SDNode<"ARMISD::VREV16", SDTARMVSHUF>; -def NEONvsplat0 : SDNode<"ARMISD::VSPLAT0", SDTARMVSHUF>; //===----------------------------------------------------------------------===// // NEON operand definitions @@ -1745,14 +1744,20 @@ def : Pat<(v2f64 (insertelt QPR:$src1, DPR:$src2, imm:$src3)), // VDUP : Vector Duplicate (from ARM core register to all elements) +def splat_lo : PatFrag<(ops node:$lhs, node:$rhs), + (vector_shuffle node:$lhs, node:$rhs), [{ + ShuffleVectorSDNode *SVOp = cast(N); + return SVOp->isSplat() && SVOp->getSplatIndex() == 0; +}]>; + class VDUPD opcod1, bits<2> opcod3, string asmSize, ValueType Ty> : NVDup; + [(set DPR:$dst, (Ty (splat_lo (scalar_to_vector GPR:$src), undef)))]>; class VDUPQ opcod1, bits<2> opcod3, string asmSize, ValueType Ty> : NVDup; + [(set QPR:$dst, (Ty (splat_lo (scalar_to_vector GPR:$src), undef)))]>; def VDUP8d : VDUPD<0b11101100, 0b00, ".8", v8i8>; def VDUP16d : VDUPD<0b11101000, 0b01, ".16", v4i16>; @@ -1763,14 +1768,16 @@ def VDUP32q : VDUPQ<0b11101010, 0b00, ".32", v4i32>; def VDUPfd : NVDup<0b11101000, 0b1011, 0b00, (outs DPR:$dst), (ins GPR:$src), NoItinerary, "vdup", ".32\t$dst, $src", - [(set DPR:$dst, - (v2f32 (NEONvsplat0 (scalar_to_vector - (f32 (bitconvert GPR:$src))))))]>; + [(set DPR:$dst, (v2f32 (splat_lo + (scalar_to_vector + (f32 (bitconvert GPR:$src))), + undef)))]>; def VDUPfq : NVDup<0b11101010, 0b1011, 0b00, (outs QPR:$dst), (ins GPR:$src), NoItinerary, "vdup", ".32\t$dst, $src", - [(set QPR:$dst, - (v4f32 (NEONvsplat0 (scalar_to_vector - (f32 (bitconvert GPR:$src))))))]>; + [(set QPR:$dst, (v4f32 (splat_lo + (scalar_to_vector + (f32 (bitconvert GPR:$src))), + undef)))]>; // VDUP : Vector Duplicate Lane (from scalar to all elements) @@ -1812,14 +1819,16 @@ def VDUPLNfq : VDUPLNQ<0b01, 0b00, "vdup.32", v4f32, v2f32>; def VDUPfdf : N2V<0b11, 0b11, 0b01, 0b00, 0b11000, 0, 0, (outs DPR:$dst), (ins SPR:$src), NoItinerary, "vdup.32\t$dst, ${src:lane}", "", - [(set DPR:$dst, (v2f32 (NEONvsplat0 - (scalar_to_vector SPR:$src))))]>; + [(set DPR:$dst, (v2f32 (splat_lo + (scalar_to_vector SPR:$src), + undef)))]>; def VDUPfqf : N2V<0b11, 0b11, 0b01, 0b00, 0b11000, 1, 0, (outs QPR:$dst), (ins SPR:$src), NoItinerary, "vdup.32\t$dst, ${src:lane}", "", - [(set QPR:$dst, (v4f32 (NEONvsplat0 - (scalar_to_vector SPR:$src))))]>; + [(set QPR:$dst, (v4f32 (splat_lo + (scalar_to_vector SPR:$src), + undef)))]>; // VMOVN : Vector Narrowing Move defm VMOVN : N2VNInt_HSD<0b11,0b11,0b10,0b00100,0,0, "vmovn.i", -- 2.34.1