From ac2d2e0a3db575c216e0a6f8f5dae59adcf08e07 Mon Sep 17 00:00:00 2001 From: Alp Toker Date: Wed, 22 Jan 2014 22:17:51 +0000 Subject: [PATCH] Tweak r199835 to use can_execute() instead of exists() The execution code path crashes if it can't execute the binary so we might as well take precautions here. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@199844 91177308-0d34-0410-b5e6-96231b3b80d8 --- tools/lli/lli.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/lli/lli.cpp b/tools/lli/lli.cpp index e6d4087476f..e36d9179584 100644 --- a/tools/lli/lli.cpp +++ b/tools/lli/lli.cpp @@ -668,8 +668,9 @@ int main(int argc, char **argv, char * const *envp) { << " Defaulting to simulated remote execution\n"; Target.reset(RemoteTarget::createRemoteTarget()); } else { - if (!sys::fs::exists(ChildExecPath)) { - errs() << "Unable to find child target: '" << ChildExecPath << "'\n"; + if (!sys::fs::can_execute(ChildExecPath)) { + errs() << "Unable to find usable child executable: '" << ChildExecPath + << "'\n"; return -1; } Target.reset(RemoteTarget::createExternalRemoteTarget(ChildExecPath)); -- 2.34.1