From a4a48cc2b1a377a2d086c1be8fe2d69e659e29be Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Tue, 6 Jan 2015 12:48:38 -0800 Subject: [PATCH] folly/gen/Parallel-inl.h: trivial -Wsign-compare fix Summary: * folly/gen/Parallel-inl.h (folly): Use a for-loop index of type size_t (not "int") to match type of upper bound. Otherwise, gcc-4.9 fails with this: folly/gen/Parallel-inl.h:242:27: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Test Plan: Run this and note there are fewer errors than before: fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo Reviewed By: davejwatson@fb.com Subscribers: folly-diffs@ FB internal diff: D1767160 Tasks: 5941250 Signature: t1:1767160:1420577886:6acfb7f6d50ed715dcf4058841aeabc39fa99cbc --- folly/gen/Parallel-inl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/gen/Parallel-inl.h b/folly/gen/Parallel-inl.h index ab37f7d8..666acb16 100644 --- a/folly/gen/Parallel-inl.h +++ b/folly/gen/Parallel-inl.h @@ -239,7 +239,7 @@ class Parallel : public Operator> { ops_(ops) { inQueue_.openProducer(); outQueue_.openConsumer(); - for (int t = 0; t < threads; ++t) { + for (size_t t = 0; t < threads; ++t) { inQueue_.openConsumer(); outQueue_.openProducer(); workers_.emplace_back([this] { -- 2.34.1