From 9fdd48c18421d9d050740522cfe189e1aebe59d2 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Mon, 5 Oct 2015 13:02:43 +0000 Subject: [PATCH] [Support] Add a version of fs::make_absolute with a custom CWD. This will be used soon from clang. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@249309 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/Support/FileSystem.h | 14 ++++++++++++++ lib/Support/Path.cpp | 17 +++++++++++++++-- unittests/Support/Path.cpp | 4 ++++ 3 files changed, 33 insertions(+), 2 deletions(-) diff --git a/include/llvm/Support/FileSystem.h b/include/llvm/Support/FileSystem.h index 48a2f0a748b..84d7e85b381 100644 --- a/include/llvm/Support/FileSystem.h +++ b/include/llvm/Support/FileSystem.h @@ -266,6 +266,20 @@ private: /// @name Physical Operators /// @{ +/// @brief Make \a path an absolute path. +/// +/// Makes \a path absolute using the \a current_directory if it is not already. +/// An empty \a path will result in the \a current_directory. +/// +/// /absolute/path => /absolute/path +/// relative/../path => /relative/../path +/// +/// @param path A path that is modified to be an absolute path. +/// @returns errc::success if \a path has been made absolute, otherwise a +/// platform-specific error_code. +std::error_code make_absolute(const Twine ¤t_directory, + SmallVectorImpl &path); + /// @brief Make \a path an absolute path. /// /// Makes \a path absolute using the current directory if it is not already. An diff --git a/lib/Support/Path.cpp b/lib/Support/Path.cpp index aa96074554e..653a984194a 100644 --- a/lib/Support/Path.cpp +++ b/lib/Support/Path.cpp @@ -740,7 +740,9 @@ std::error_code createUniqueDirectory(const Twine &Prefix, true, 0, FS_Dir); } -std::error_code make_absolute(SmallVectorImpl &path) { +static std::error_code make_absolute(const Twine ¤t_directory, + SmallVectorImpl &path, + bool use_current_directory) { StringRef p(path.data(), path.size()); bool rootDirectory = path::has_root_directory(p), @@ -756,7 +758,9 @@ std::error_code make_absolute(SmallVectorImpl &path) { // All of the following conditions will need the current directory. SmallString<128> current_dir; - if (std::error_code ec = current_path(current_dir)) + if (use_current_directory) + current_directory.toVector(current_dir); + else if (std::error_code ec = current_path(current_dir)) return ec; // Relative path. Prepend the current directory. @@ -793,6 +797,15 @@ std::error_code make_absolute(SmallVectorImpl &path) { "occurred above!"); } +std::error_code make_absolute(const Twine ¤t_directory, + SmallVectorImpl &path) { + return make_absolute(current_directory, path, true); +} + +std::error_code make_absolute(SmallVectorImpl &path) { + return make_absolute(Twine(), path, false); +} + std::error_code create_directories(const Twine &Path, bool IgnoreExisting, perms Perms) { SmallString<128> PathStorage; diff --git a/unittests/Support/Path.cpp b/unittests/Support/Path.cpp index a4d2ab1bfc8..f35682e19b7 100644 --- a/unittests/Support/Path.cpp +++ b/unittests/Support/Path.cpp @@ -150,6 +150,10 @@ TEST(Support, Path) { path::native(*i, temp_store); } + + SmallString<32> Relative("foo.cpp"); + ASSERT_NO_ERROR(sys::fs::make_absolute("/root", Relative)); + ASSERT_EQ("/root/foo.cpp", Relative); } TEST(Support, RelativePathIterator) { -- 2.34.1