From 932660ce7ecffeb65c15dc9844d60a42876805b4 Mon Sep 17 00:00:00 2001 From: Hans Verkuil Date: Mon, 16 Dec 2013 16:45:24 +0100 Subject: [PATCH] CHROMIUM: videodev2.h: add config_store to v4l2_ext_controls The ctrl_class is fairly pointless when used with drivers that use the control framework: you can just fill in 0 and it will just work fine. There are still some old unconverted drivers that do not support 0 and instead want the control class there. The idea being that all controls in the list all belong to that class. This was done to simplify drivers in the absence of the control framework. When using the control framework the framework itself is smart enough to allow controls of any class to be included in the control list. Since configuration store IDs are in the range 1..255 (or so, in any case a relatively small non-zero positive integer) it makes sense to effectively rename ctrl_class to config_store. Set it to 0 and you get the normal behavior (you change the current control value), set it to a configuration store ID and you get/set the control for that store. Signed-off-by: Hans Verkuil BUG=chrome-os-partner:33728 TEST=build Signed-off-by: Pawel Osciak Reviewed-on: https://chromium-review.googlesource.com/232582 Trybot-Ready: Tomasz Figa Tested-by: Tomasz Figa Reviewed-by: Wu-cheng Li Commit-Queue: Tomasz Figa Conflicts: include/uapi/linux/videodev2.h Change-Id: I862bb5796e27bcbbd055e22202ac9a1ed0cc6f7d Signed-off-by: Jeffy Chen Signed-off-by: Yakir Yang --- include/uapi/linux/videodev2.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/videodev2.h b/include/uapi/linux/videodev2.h index 62449b5ad395..d507509baed0 100644 --- a/include/uapi/linux/videodev2.h +++ b/include/uapi/linux/videodev2.h @@ -1481,6 +1481,7 @@ struct v4l2_ext_controls { __u32 ctrl_class; #endif __u32 which; + __u32 config_store; }; __u32 count; __u32 error_idx; -- 2.34.1