From 92d9e7f79ad61be45997c62e00a23a02c728c345 Mon Sep 17 00:00:00 2001 From: Yedidya Feldblum Date: Sat, 29 Jul 2017 17:54:14 -0700 Subject: [PATCH] Mark two implicit ctors as explicit Summary: [Folly] Mark two implicit ctors as `explicit`. They did not need to be implicit. Reviewed By: andrewjcg Differential Revision: D5524798 fbshipit-source-id: a50bc6bfc9da2642891faf0aa38a19f46e75b9da --- folly/io/IOBuf.cpp | 4 +--- folly/test/DeterministicScheduleTest.cpp | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/folly/io/IOBuf.cpp b/folly/io/IOBuf.cpp index 91f7d8de..80741e3e 100644 --- a/folly/io/IOBuf.cpp +++ b/folly/io/IOBuf.cpp @@ -84,9 +84,7 @@ void takeOwnershipError(bool freeOnError, void* buf, namespace folly { struct IOBuf::HeapPrefix { - HeapPrefix(uint16_t flg) - : magic(kHeapMagic), - flags(flg) {} + explicit HeapPrefix(uint16_t flg) : magic(kHeapMagic), flags(flg) {} ~HeapPrefix() { // Reset magic to 0 on destruction. This is solely for debugging purposes // to help catch bugs where someone tries to use HeapStorage after it has diff --git a/folly/test/DeterministicScheduleTest.cpp b/folly/test/DeterministicScheduleTest.cpp index 331e42e3..f494ad37 100644 --- a/folly/test/DeterministicScheduleTest.cpp +++ b/folly/test/DeterministicScheduleTest.cpp @@ -316,7 +316,7 @@ struct AnnotatedAtomicCounter : public Base { } /* Constructor -- calls original constructor */ - AnnotatedAtomicCounter(int val) : Base(val) {} + explicit AnnotatedAtomicCounter(int val) : Base(val) {} /* Overloads of original member functions (as needed) */ -- 2.34.1