From 90678e67d54d87835b6ee9d58696497e43809908 Mon Sep 17 00:00:00 2001 From: Andrii Grynenko Date: Fri, 6 May 2016 22:02:15 -0700 Subject: [PATCH] Don't re-throw exceptions from default FiberManager exception handler Summary: It's very unlikely that caller will handle such exceptions and FiberManager can proceed even if one task failed. DFATAL will ensure we still fail on such exceptions in debug builds. Reviewed By: yfeldblum Differential Revision: D3273573 fb-gh-sync-id: 55eba19c16429a3c89a2fdf5363fd4b55b3998a2 fbshipit-source-id: 55eba19c16429a3c89a2fdf5363fd4b55b3998a2 --- folly/experimental/fibers/FiberManager-inl.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/folly/experimental/fibers/FiberManager-inl.h b/folly/experimental/fibers/FiberManager-inl.h index 1e91a5a6..52c283f5 100644 --- a/folly/experimental/fibers/FiberManager-inl.h +++ b/folly/experimental/fibers/FiberManager-inl.h @@ -527,11 +527,9 @@ FiberManager::FiberManager( LOG(DFATAL) << "Exception " << typeid(e).name() << " with message '" << e.what() << "' was thrown in " << "FiberManager with context '" << context << "'"; - throw; } catch (...) { LOG(DFATAL) << "Unknown exception was thrown in FiberManager with " << "context '" << context << "'"; - throw; } }), timeoutManager_(std::make_shared(*loopController_)), -- 2.34.1