From 8d6162a4bec995ec3aaa0cbd7a203738b350425b Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Mon, 6 Jul 2009 23:11:08 +0000 Subject: [PATCH] Add FIXMEs. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@74879 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Target/PIC16/PIC16DebugInfo.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/Target/PIC16/PIC16DebugInfo.cpp b/lib/Target/PIC16/PIC16DebugInfo.cpp index 430058805dd..af627a3b724 100644 --- a/lib/Target/PIC16/PIC16DebugInfo.cpp +++ b/lib/Target/PIC16/PIC16DebugInfo.cpp @@ -200,6 +200,7 @@ short PIC16DbgInfo::getStorageClass(DIGlobalVariable DIGV) { /// required initializations. void PIC16DbgInfo::BeginModule(Module &M) { // Emit file directive for module. + // FIXME : What if more then one CUs are present in a module ? GlobalVariable *CU = M.getNamedGlobal("llvm.dbg.compile_unit"); if (CU) { EmitDebugDirectives = true; @@ -321,6 +322,7 @@ void PIC16DbgInfo::EmitCompositeTypeDecls(Module &M) { E = M.getGlobalList().end(); I != E; I++) { // Structures and union declaration's debug info has llvm.dbg.composite // in its name. + // FIXME: Checking and relying on llvm.dbg.composite name is not a good idea. if(I->getName().find("llvm.dbg.composite") != std::string::npos) { GlobalVariable *GV = cast(I); DICompositeType CTy(GV); @@ -425,6 +427,7 @@ void PIC16DbgInfo::EmitSymbol(std::string Name, short Class, unsigned short /// EmitVarDebugInfo - Emit debug information for all variables. /// void PIC16DbgInfo::EmitVarDebugInfo(Module &M) { + // FIXME : This anchor has been removed. GlobalVariable *Root = M.getGlobalVariable("llvm.dbg.global_variables"); if (!Root) return; -- 2.34.1