From 88cac3d2f70d01423f56363f24e172786428b3cf Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Wed, 11 Jan 2006 05:10:20 +0000 Subject: [PATCH] Switch these to using ETForest instead of DominatorSet to compute itself. Patch written by Daniel Berlin! git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@25202 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/GCSE.cpp | 6 +++--- lib/Transforms/Scalar/LoopStrengthReduce.cpp | 15 ++++++++------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/lib/Transforms/Scalar/GCSE.cpp b/lib/Transforms/Scalar/GCSE.cpp index a785685b2cd..3d6e6248118 100644 --- a/lib/Transforms/Scalar/GCSE.cpp +++ b/lib/Transforms/Scalar/GCSE.cpp @@ -45,7 +45,7 @@ namespace { // This transformation requires dominator and immediate dominator info virtual void getAnalysisUsage(AnalysisUsage &AU) const { AU.setPreservesCFG(); - AU.addRequired(); + AU.addRequired(); AU.addRequired(); AU.addRequired(); } @@ -64,7 +64,7 @@ bool GCSE::runOnFunction(Function &F) { bool Changed = false; // Get pointers to the analysis results that we will be using... - DominatorSet &DS = getAnalysis(); + ETForest &EF = getAnalysis(); ValueNumbering &VN = getAnalysis(); DominatorTree &DT = getAnalysis(); @@ -141,7 +141,7 @@ bool GCSE::runOnFunction(Function &F) { if (OtherI->getParent() == BB) Dominates = BlockInsts.count(OtherI); else - Dominates = DS.dominates(OtherI->getParent(), BB); + Dominates = EF.dominates(OtherI->getParent(), BB); if (Dominates) { // Okay, we found an instruction with the same value as this one diff --git a/lib/Transforms/Scalar/LoopStrengthReduce.cpp b/lib/Transforms/Scalar/LoopStrengthReduce.cpp index f170592ece3..ebd2bf055bc 100644 --- a/lib/Transforms/Scalar/LoopStrengthReduce.cpp +++ b/lib/Transforms/Scalar/LoopStrengthReduce.cpp @@ -77,7 +77,7 @@ namespace { class LoopStrengthReduce : public FunctionPass { LoopInfo *LI; - DominatorSet *DS; + ETForest *EF; ScalarEvolution *SE; const TargetData *TD; const Type *UIntPtrTy; @@ -111,7 +111,7 @@ namespace { virtual bool runOnFunction(Function &) { LI = &getAnalysis(); - DS = &getAnalysis(); + EF = &getAnalysis(); SE = &getAnalysis(); TD = &getAnalysis(); UIntPtrTy = TD->getIntPtrType(); @@ -129,13 +129,14 @@ namespace { AU.addPreservedID(LoopSimplifyID); AU.addPreserved(); AU.addPreserved(); + AU.addPreserved(); AU.addPreserved(); AU.addPreserved(); AU.addPreserved(); AU.addRequiredID(LoopSimplifyID); AU.addRequired(); - AU.addRequired(); + AU.addRequired(); AU.addRequired(); AU.addRequired(); } @@ -324,7 +325,7 @@ static bool getSCEVStartAndStride(const SCEVHandle &SH, Loop *L, /// the loop, resulting in reg-reg copies (if we use the pre-inc value when we /// should use the post-inc value). static bool IVUseShouldUsePostIncValue(Instruction *User, Instruction *IV, - Loop *L, DominatorSet *DS, Pass *P) { + Loop *L, ETForest *EF, Pass *P) { // If the user is in the loop, use the preinc value. if (L->contains(User->getParent())) return false; @@ -332,7 +333,7 @@ static bool IVUseShouldUsePostIncValue(Instruction *User, Instruction *IV, // Ok, the user is outside of the loop. If it is dominated by the latch // block, use the post-inc value. - if (DS->dominates(LatchBlock, User->getParent())) + if (EF->dominates(LatchBlock, User->getParent())) return true; // There is one case we have to be careful of: PHI nodes. These little guys @@ -349,7 +350,7 @@ static bool IVUseShouldUsePostIncValue(Instruction *User, Instruction *IV, for (unsigned i = 0, e = PN->getNumIncomingValues(); i != e; ++i) if (PN->getIncomingValue(i) == IV) { ++NumUses; - if (!DS->dominates(LatchBlock, PN->getIncomingBlock(i))) + if (!EF->dominates(LatchBlock, PN->getIncomingBlock(i))) return false; } @@ -415,7 +416,7 @@ bool LoopStrengthReduce::AddUsersIfInteresting(Instruction *I, Loop *L, // Okay, we found a user that we cannot reduce. Analyze the instruction // and decide what to do with it. If we are a use inside of the loop, use // the value before incrementation, otherwise use it after incrementation. - if (IVUseShouldUsePostIncValue(User, I, L, DS, this)) { + if (IVUseShouldUsePostIncValue(User, I, L, EF, this)) { // The value used will be incremented by the stride more than we are // expecting, so subtract this off. SCEVHandle NewStart = SCEV::getMinusSCEV(Start, Stride); -- 2.34.1