From 832ecb9f330fa34eb47d0b6858aa48c04097d128 Mon Sep 17 00:00:00 2001 From: Nicholas Ormrod Date: Mon, 17 Nov 2014 15:47:05 -0800 Subject: [PATCH] Fix build break Summary: Change counting index to unsigned to avoid unsigned-signed comparison errors. @build-break Test Plan: fbconfig -r folly && fbmake dbg fbmake runtests wangle Reviewed By: robbert@fb.com, davejwatson@fb.com Subscribers: sdwilsh, fugalh, njormrod, folly-diffs@ FB internal diff: D1686315 Signature: t1:1686315:1416267974:d8f6075550b9d611790263338dd4f49e7ef451cc Blame Revision: D1595200 --- folly/experimental/wangle/rx/test/RxBenchmark.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/folly/experimental/wangle/rx/test/RxBenchmark.cpp b/folly/experimental/wangle/rx/test/RxBenchmark.cpp index 5a14bbc6..c4123100 100644 --- a/folly/experimental/wangle/rx/test/RxBenchmark.cpp +++ b/folly/experimental/wangle/rx/test/RxBenchmark.cpp @@ -27,7 +27,7 @@ static std::unique_ptr> makeObserver() { } void subscribeImpl(uint iters, int N, bool countUnsubscribe) { - for (int iter = 0; iter < iters; iter++) { + for (uint iter = 0; iter < iters; iter++) { BenchmarkSuspender bs; Subject subject; std::vector>> observers; @@ -56,7 +56,7 @@ void subscribe(uint iters, int N) { } void observe(uint iters, int N) { - for (int iter = 0; iter < iters; iter++) { + for (uint iter = 0; iter < iters; iter++) { BenchmarkSuspender bs; Subject subject; std::vector>> observers; @@ -72,7 +72,7 @@ void observe(uint iters, int N) { } void inlineObserve(uint iters, int N) { - for (int iter = 0; iter < iters; iter++) { + for (uint iter = 0; iter < iters; iter++) { BenchmarkSuspender bs; Subject subject; std::vector*> observers; @@ -91,7 +91,7 @@ void inlineObserve(uint iters, int N) { } void notifySubscribers(uint iters, int N) { - for (int iter = 0; iter < iters; iter++) { + for (uint iter = 0; iter < iters; iter++) { BenchmarkSuspender bs; Subject subject; std::vector>> observers; @@ -110,7 +110,7 @@ void notifySubscribers(uint iters, int N) { } void notifyInlineObservers(uint iters, int N) { - for (int iter = 0; iter < iters; iter++) { + for (uint iter = 0; iter < iters; iter++) { BenchmarkSuspender bs; Subject subject; std::vector*> observers; -- 2.34.1