From 6f8694b272ffbd5b4746feccd4866bf89794fe86 Mon Sep 17 00:00:00 2001 From: Victor Hernandez Date: Wed, 20 Jan 2010 06:22:33 +0000 Subject: [PATCH] Fix if/else brackets; getFunctionForValue() is to be called for non-metadata values git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@93984 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/VMCore/Metadata.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp index b4a981f3a02..acc3b8ee5ef 100644 --- a/lib/VMCore/Metadata.cpp +++ b/lib/VMCore/Metadata.cpp @@ -122,6 +122,7 @@ MDNode::~MDNode() { } static const Function *getFunctionForValue(Value *V) { + assert(!isa(V) && "does not iterate over metadata operands"); if (!V) return NULL; if (Instruction *I = dyn_cast(V)) return I->getParent()->getParent(); @@ -161,7 +162,8 @@ const Function *MDNode::getFunction() const { if (Value *V = getOperand(i)) { if (MDNode *MD = dyn_cast(V)) { if (const Function *F = MD->getFunction()) return F; - else return getFunctionForValue(V); + } else { + return getFunctionForValue(V); } } } -- 2.34.1