From 660b5fc4d019bf22fbe14dfb81c5b59444fa3506 Mon Sep 17 00:00:00 2001 From: Rafael Espindola Date: Fri, 3 Dec 2010 01:19:49 +0000 Subject: [PATCH] Do with uleb the same trick we now do with dwarf line/address advances. This avoids creating leb128 fragments and speeds up the test in PR8711 to 33s. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@120774 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/MC/MCAsmStreamer.cpp | 10 ++-------- lib/MC/MCObjectStreamer.cpp | 10 ++++++++++ lib/MC/MCStreamer.cpp | 10 ++++++++-- 3 files changed, 20 insertions(+), 10 deletions(-) diff --git a/lib/MC/MCAsmStreamer.cpp b/lib/MC/MCAsmStreamer.cpp index 217daed7fe0..5c9a347c3c0 100644 --- a/lib/MC/MCAsmStreamer.cpp +++ b/lib/MC/MCAsmStreamer.cpp @@ -546,10 +546,7 @@ void MCAsmStreamer::EmitValue(const MCExpr *Value, unsigned Size, void MCAsmStreamer::EmitULEB128Value(const MCExpr *Value, unsigned AddrSpace) { int64_t IntValue; if (Value->EvaluateAsAbsolute(IntValue)) { - SmallString<32> Tmp; - raw_svector_ostream OSE(Tmp); - MCObjectWriter::EncodeULEB128(IntValue, OSE); - EmitBytes(OSE.str(), AddrSpace); + EmitULEB128IntValue(IntValue, AddrSpace); return; } assert(MAI.hasLEB128() && "Cannot print a .uleb"); @@ -560,10 +557,7 @@ void MCAsmStreamer::EmitULEB128Value(const MCExpr *Value, unsigned AddrSpace) { void MCAsmStreamer::EmitSLEB128Value(const MCExpr *Value, unsigned AddrSpace) { int64_t IntValue; if (Value->EvaluateAsAbsolute(IntValue)) { - SmallString<32> Tmp; - raw_svector_ostream OSE(Tmp); - MCObjectWriter::EncodeSLEB128(IntValue, OSE); - EmitBytes(OSE.str(), AddrSpace); + EmitSLEB128IntValue(IntValue, AddrSpace); return; } assert(MAI.hasLEB128() && "Cannot print a .sleb"); diff --git a/lib/MC/MCObjectStreamer.cpp b/lib/MC/MCObjectStreamer.cpp index 506c963c591..f6753e3d1e1 100644 --- a/lib/MC/MCObjectStreamer.cpp +++ b/lib/MC/MCObjectStreamer.cpp @@ -115,11 +115,21 @@ void MCObjectStreamer::EmitLabel(MCSymbol *Symbol) { void MCObjectStreamer::EmitULEB128Value(const MCExpr *Value, unsigned AddrSpace) { + int64_t IntValue; + if (Value->EvaluateAsAbsolute(IntValue, &getAssembler())) { + EmitULEB128IntValue(IntValue, AddrSpace); + return; + } new MCLEBFragment(*Value, false, getCurrentSectionData()); } void MCObjectStreamer::EmitSLEB128Value(const MCExpr *Value, unsigned AddrSpace) { + int64_t IntValue; + if (Value->EvaluateAsAbsolute(IntValue, &getAssembler())) { + EmitSLEB128IntValue(IntValue, AddrSpace); + return; + } new MCLEBFragment(*Value, true, getCurrentSectionData()); } diff --git a/lib/MC/MCStreamer.cpp b/lib/MC/MCStreamer.cpp index 9fe719a7fa7..38ace6b2ee2 100644 --- a/lib/MC/MCStreamer.cpp +++ b/lib/MC/MCStreamer.cpp @@ -52,13 +52,19 @@ void MCStreamer::EmitIntValue(uint64_t Value, unsigned Size, /// EmitULEB128Value - Special case of EmitULEB128Value that avoids the /// client having to pass in a MCExpr for constant integers. void MCStreamer::EmitULEB128IntValue(uint64_t Value, unsigned AddrSpace) { - EmitULEB128Value(MCConstantExpr::Create(Value, getContext()), AddrSpace); + SmallString<32> Tmp; + raw_svector_ostream OSE(Tmp); + MCObjectWriter::EncodeULEB128(Value, OSE); + EmitBytes(OSE.str(), AddrSpace); } /// EmitSLEB128Value - Special case of EmitSLEB128Value that avoids the /// client having to pass in a MCExpr for constant integers. void MCStreamer::EmitSLEB128IntValue(int64_t Value, unsigned AddrSpace) { - EmitSLEB128Value(MCConstantExpr::Create(Value, getContext()), AddrSpace); + SmallString<32> Tmp; + raw_svector_ostream OSE(Tmp); + MCObjectWriter::EncodeSLEB128(Value, OSE); + EmitBytes(OSE.str(), AddrSpace); } void MCStreamer::EmitSymbolValue(const MCSymbol *Sym, unsigned Size, -- 2.34.1