From 65d64c0d7d7d23b5bf0c4e52d66d2caeb5f06ced Mon Sep 17 00:00:00 2001 From: Nathan Bronson Date: Wed, 7 Dec 2016 11:39:00 -0800 Subject: [PATCH] fix FutureTest/RequestContext Summary: Fix use-after-destroy of NewThreadExecutor. Detected by opt-ubsan tests. Reviewed By: yfeldblum Differential Revision: D4291900 fbshipit-source-id: 206f1d7b80fa04e1570e4b7a20e50b9a8ceb7bcb --- folly/futures/test/FutureTest.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/futures/test/FutureTest.cpp b/folly/futures/test/FutureTest.cpp index 7d0275d6..5dc02dd2 100644 --- a/folly/futures/test/FutureTest.cpp +++ b/folly/futures/test/FutureTest.cpp @@ -822,8 +822,8 @@ TEST(Future, RequestContext) { }; Promise p1, p2; + NewThreadExecutor e; { - NewThreadExecutor e; folly::RequestContextScopeGuard rctx; RequestContext::get()->setContextData( "key", folly::make_unique(true)); -- 2.34.1