From 6150806853b9fe36f9a02277c583787f4cb026f0 Mon Sep 17 00:00:00 2001 From: Michael Kruse Date: Fri, 18 Sep 2015 10:56:30 +0000 Subject: [PATCH] [Support] Reapply r245289 "Always wait for GraphViz before opening the viewer" The change was accidentally undone by r245290. Original log message: When calling DisplayGraph and a PS viewer is chosen, two programs are executed: The GraphViz generator and the PostScript viewer. Always wait for the generator to finish to ensure that the .ps file is written before opening the viewer for that file. DisplayGraph's wait parameter refers to whether to wait until the user closes the viewer. This happened on Windows and if none of the options to open the .dot file directly applies, also on Linux. Differential Revision: http://reviews.llvm.org/D11876 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@247980 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/GraphWriter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Support/GraphWriter.cpp b/lib/Support/GraphWriter.cpp index b80fbdb0d08..d0e1d50e8cc 100644 --- a/lib/Support/GraphWriter.cpp +++ b/lib/Support/GraphWriter.cpp @@ -234,7 +234,7 @@ bool llvm::DisplayGraph(StringRef FilenameRef, bool wait, errs() << "Running '" << GeneratorPath << "' program... "; - if (ExecGraphViewer(GeneratorPath, args, Filename, wait, ErrMsg)) + if (ExecGraphViewer(GeneratorPath, args, Filename, true, ErrMsg)) return true; // The lifetime of StartArg must include the call of ExecGraphViewer -- 2.34.1