From 5cbaa0fd22adcaf860c6237f90c43e92bd3e6679 Mon Sep 17 00:00:00 2001 From: Vladimir Tkachev Date: Fri, 17 Jan 2014 13:49:41 -0800 Subject: [PATCH] Remove byLine(const char*) method Summary: Many callers of byLine method use it by providing arguments for File explicit constructors. Added function breaks byLine(file desciptor) use case. Commenting it out until File constructors are made exlicit to fix failing tests. Test Plan: unittest Reviewed By: lucian@fb.com FB internal diff: D1133938 Blame Revision: D1129497 --- folly/experimental/FileGen-inl.h | 8 -------- 1 file changed, 8 deletions(-) diff --git a/folly/experimental/FileGen-inl.h b/folly/experimental/FileGen-inl.h index 2825d68e..79f8a1dd 100644 --- a/folly/experimental/FileGen-inl.h +++ b/folly/experimental/FileGen-inl.h @@ -135,12 +135,4 @@ inline auto byLine(File file, char delim = '\n') | resplit(delim); } -/** - * Ditto, take the filename and opens it - */ -inline auto byLine(const char* fileName, char delim = '\n') - -> decltype(byLine(File(fileName))) { - return byLine(File(fileName), delim); -} - }} // !folly::gen -- 2.34.1