From 531afb166c28d20b34de657ef772694e30775ca0 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 20 Oct 2011 04:05:33 +0000 Subject: [PATCH] A FIXME about block addresses and indirectbr. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@142569 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Analysis/InlineCost.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/Analysis/InlineCost.cpp b/lib/Analysis/InlineCost.cpp index 40ac9a211af..1f332e84e6e 100644 --- a/lib/Analysis/InlineCost.cpp +++ b/lib/Analysis/InlineCost.cpp @@ -135,6 +135,12 @@ void CodeMetrics::analyzeBasicBlock(const BasicBlock *BB, // for example) would be referring to the original function, and this indirect // jump would jump from the inlined copy of the function into the original // function which is extremely undefined behavior. + // FIXME: This logic isn't really right; we can safely inline functions + // with indirectbr's as long as no other function or global references the + // blockaddress of a block within the current function. And as a QOI issue, + // if someone is using a blockaddress wihtout an indirectbr, and that + // reference somehow ends up in another function or global, we probably + // don't want to inline this function. if (isa(BB->getTerminator())) containsIndirectBr = true; -- 2.34.1