From 5310cdbcc909a7c35d4c7df0fd5703850a9db2a5 Mon Sep 17 00:00:00 2001 From: Kai Nacke Date: Mon, 8 Jul 2013 04:48:34 +0000 Subject: [PATCH] Revert: Fix wrong code offset for unwind code SET_FPREG. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185793 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/MC/MCStreamer.cpp | 4 +--- lib/MC/MCWin64EH.cpp | 5 +++-- test/MC/COFF/seh.s | 2 ++ test/tools/llvm-objdump/win64-unwind-data.s | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/lib/MC/MCStreamer.cpp b/lib/MC/MCStreamer.cpp index fb43a4adbda..6542f42a03b 100644 --- a/lib/MC/MCStreamer.cpp +++ b/lib/MC/MCStreamer.cpp @@ -470,9 +470,7 @@ void MCStreamer::EmitWin64EHSetFrame(unsigned Register, unsigned Offset) { report_fatal_error("Frame register and offset already specified!"); if (Offset & 0x0F) report_fatal_error("Misaligned frame pointer offset!"); - MCSymbol *Label = getContext().CreateTempSymbol(); - MCWin64EHInstruction Inst(Win64EH::UOP_SetFPReg, Label, Register, Offset); - EmitLabel(Label); + MCWin64EHInstruction Inst(Win64EH::UOP_SetFPReg, 0, Register, Offset); CurFrame->LastFrameInst = CurFrame->Instructions.size(); CurFrame->Instructions.push_back(Inst); } diff --git a/lib/MC/MCWin64EH.cpp b/lib/MC/MCWin64EH.cpp index 8db1fa2a93c..c5b637c9244 100644 --- a/lib/MC/MCWin64EH.cpp +++ b/lib/MC/MCWin64EH.cpp @@ -64,7 +64,7 @@ static void EmitAbsDifference(MCStreamer &streamer, MCSymbol *lhs, static void EmitUnwindCode(MCStreamer &streamer, MCSymbol *begin, MCWin64EHInstruction &inst) { - uint8_t b2; + uint8_t b1, b2; uint16_t w; b2 = (inst.getOperation() & 0x0F); switch (inst.getOperation()) { @@ -93,7 +93,8 @@ static void EmitUnwindCode(MCStreamer &streamer, MCSymbol *begin, streamer.EmitIntValue(b2, 1); break; case Win64EH::UOP_SetFPReg: - EmitAbsDifference(streamer, inst.getLabel(), begin); + b1 = inst.getOffset() & 0xF0; + streamer.EmitIntValue(b1, 1); streamer.EmitIntValue(b2, 1); break; case Win64EH::UOP_SaveNonVol: diff --git a/test/MC/COFF/seh.s b/test/MC/COFF/seh.s index b1e61a97739..bef425efb43 100644 --- a/test/MC/COFF/seh.s +++ b/test/MC/COFF/seh.s @@ -1,5 +1,7 @@ // This test checks that the SEH directives emit the correct unwind data. +// TODO: Expected fail because SET_FPREG has a wrong offset. +// XFAIL: * // RUN: llvm-mc -triple x86_64-pc-win32 -filetype=obj %s | llvm-readobj -s -u | FileCheck %s // CHECK: Sections [ diff --git a/test/tools/llvm-objdump/win64-unwind-data.s b/test/tools/llvm-objdump/win64-unwind-data.s index a172bfca6b3..1e4c7428ce3 100644 --- a/test/tools/llvm-objdump/win64-unwind-data.s +++ b/test/tools/llvm-objdump/win64-unwind-data.s @@ -13,7 +13,7 @@ // CHECK-NEXT: Frame register: RBX // CHECK-NEXT: Frame offset: 0 // CHECK-NEXT: Unwind Codes: -// CHECK-NEXT: 0x12: UOP_SetFPReg +// CHECK-NEXT: 0x00: UOP_SetFPReg // CHECK-NEXT: 0x0f: UOP_PushNonVol RBX // CHECK-NEXT: 0x0e: UOP_SaveXMM128 XMM8 [0x0000] // CHECK-NEXT: 0x09: UOP_SaveNonVol RSI [0x0010] -- 2.34.1