From 46bf40d1c82f1190c384222b2cf9cb2525c6e081 Mon Sep 17 00:00:00 2001 From: "Zhen (Growth) Li" Date: Tue, 3 Nov 2015 17:31:55 -0800 Subject: [PATCH] switch the IndexType and Allocator in AtomicUnorderedInsertMap template Summary: Our use case need to have the IndexType Configurable, but in this diff D2583752, lint error shows Code from folly::detail is logically private, please avoid use outside of folly. In order to fix this lint error, I switch the IndexType and Allocator in the AtomicUnorderedInsertMap template. Reviewed By: nbronson Differential Revision: D2610921 fb-gh-sync-id: ae81b41e7c8c971f26c61b8c67dabeadff379584 --- folly/AtomicUnorderedMap.h | 9 ++++----- folly/test/AtomicUnorderedMapTest.cpp | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/folly/AtomicUnorderedMap.h b/folly/AtomicUnorderedMap.h index 4c0afb68..9f139de0 100644 --- a/folly/AtomicUnorderedMap.h +++ b/folly/AtomicUnorderedMap.h @@ -135,8 +135,8 @@ template ::value && boost::has_trivial_destructor::value), template class Atom = std::atomic, - typename Allocator = folly::detail::MMapAlloc, - typename IndexType = uint32_t> + typename IndexType = uint32_t, + typename Allocator = folly::detail::MMapAlloc> struct AtomicUnorderedInsertMap { @@ -493,9 +493,8 @@ using AtomicUnorderedInsertMap64 = KeyEqual, SkipKeyValueDeletion, Atom, - Allocator, - uint64_t>; - + uint64_t, + Allocator>; /// MutableAtom is a tiny wrapper than gives you the option of atomically /// updating values inserted into an AtomicUnorderedInsertMap::value && boost::has_trivial_destructor::value), Atom, - Allocator, - IndexType>; + IndexType, + Allocator>; namespace { template -- 2.34.1