From 290342a15755e9f128916eb66ec88812d6cee569 Mon Sep 17 00:00:00 2001 From: Devang Patel Date: Tue, 8 Mar 2011 03:06:19 +0000 Subject: [PATCH] While sinking an instruction, do not lose llvm.dbg.value intrinsic. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@127214 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Transforms/Scalar/LICM.cpp | 3 +- test/Transforms/LICM/debug-value.ll | 62 +++++++++++++++++++++++++++++ 2 files changed, 64 insertions(+), 1 deletion(-) create mode 100644 test/Transforms/LICM/debug-value.ll diff --git a/lib/Transforms/Scalar/LICM.cpp b/lib/Transforms/Scalar/LICM.cpp index 07867933d08..6cf1bd3deb5 100644 --- a/lib/Transforms/Scalar/LICM.cpp +++ b/lib/Transforms/Scalar/LICM.cpp @@ -445,7 +445,8 @@ void LICM::sink(Instruction &I) { // enough that we handle it as a special (more efficient) case. It is more // efficient to handle because there are no PHI nodes that need to be placed. if (ExitBlocks.size() == 1) { - if (!DT->dominates(I.getParent(), ExitBlocks[0])) { + if (!isa(I) && + !DT->dominates(I.getParent(), ExitBlocks[0])) { // Instruction is not used, just delete it. CurAST->deleteValue(&I); // If I has users in unreachable blocks, eliminate. diff --git a/test/Transforms/LICM/debug-value.ll b/test/Transforms/LICM/debug-value.ll new file mode 100644 index 00000000000..889d4e2e3af --- /dev/null +++ b/test/Transforms/LICM/debug-value.ll @@ -0,0 +1,62 @@ +; RUN: opt -licm -basicaa < %s -S | FileCheck %s + +define void @dgefa() nounwind ssp { +entry: + br label %for.body + +for.body: ; preds = %for.cond.backedge, %entry + br i1 undef, label %if.then, label %for.cond.backedge, !dbg !11 + +for.cond.backedge: ; preds = %for.body61, %for.body61.us, %for.body + br i1 undef, label %for.end104, label %for.body, !dbg !15 + +if.then: ; preds = %for.body + br i1 undef, label %if.then27, label %if.end.if.end.split_crit_edge.critedge, !dbg !16 + +if.then27: ; preds = %if.then +; CHECK: tail call void @llvm.dbg.value + tail call void @llvm.dbg.value(metadata !18, i64 0, metadata !19), !dbg !21 + br label %for.body61.us + +if.end.if.end.split_crit_edge.critedge: ; preds = %if.then + br label %for.body61 + +for.body61.us: ; preds = %for.body61.us, %if.then27 + br i1 undef, label %for.cond.backedge, label %for.body61.us, !dbg !23 + +for.body61: ; preds = %for.body61, %if.end.if.end.split_crit_edge.critedge + br i1 undef, label %for.cond.backedge, label %for.body61, !dbg !23 + +for.end104: ; preds = %for.cond.backedge + ret void, !dbg !24 +} + +declare void @llvm.dbg.value(metadata, i64, metadata) nounwind readnone + +!llvm.dbg.sp = !{!0, !6, !9, !10} + +!0 = metadata !{i32 589870, i32 0, metadata !1, metadata !"idamax", metadata !"idamax", metadata !"", metadata !1, i32 112, metadata !3, i1 false, i1 true, i32 0, i32 0, i32 0, i32 256, i1 false, null} ; [ DW_TAG_subprogram ] +!1 = metadata !{i32 589865, metadata !"/Volumes/Lalgate/work/llvm/projects/llvm-test/SingleSource/Benchmarks/CoyoteBench/lpbench.c", metadata !"/private/tmp", metadata !2} ; [ DW_TAG_file_type ] +!2 = metadata !{i32 589841, i32 0, i32 12, metadata !"/Volumes/Lalgate/work/llvm/projects/llvm-test/SingleSource/Benchmarks/CoyoteBench/lpbench.c", metadata !"/private/tmp", metadata !"clang version 2.9 (trunk 127169)", i1 true, i1 false, metadata !"", i32 0} ; [ DW_TAG_compile_unit ] +!3 = metadata !{i32 589845, metadata !1, metadata !"", metadata !1, i32 0, i64 0, i64 0, i32 0, i32 0, i32 0, metadata !4, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] +!4 = metadata !{metadata !5} +!5 = metadata !{i32 589860, metadata !2, metadata !"int", null, i32 0, i64 32, i64 32, i64 0, i32 0, i32 5} ; [ DW_TAG_base_type ] +!6 = metadata !{i32 589870, i32 0, metadata !1, metadata !"dscal", metadata !"dscal", metadata !"", metadata !1, i32 206, metadata !7, i1 false, i1 true, i32 0, i32 0, i32 0, i32 256, i1 false, null} ; [ DW_TAG_subprogram ] +!7 = metadata !{i32 589845, metadata !1, metadata !"", metadata !1, i32 0, i64 0, i64 0, i32 0, i32 0, i32 0, metadata !8, i32 0, i32 0} ; [ DW_TAG_subroutine_type ] +!8 = metadata !{null} +!9 = metadata !{i32 589870, i32 0, metadata !1, metadata !"daxpy", metadata !"daxpy", metadata !"", metadata !1, i32 230, metadata !7, i1 false, i1 true, i32 0, i32 0, i32 0, i32 256, i1 false, null} ; [ DW_TAG_subprogram ] +!10 = metadata !{i32 589870, i32 0, metadata !1, metadata !"dgefa", metadata !"dgefa", metadata !"", metadata !1, i32 267, metadata !7, i1 false, i1 true, i32 0, i32 0, i32 0, i32 256, i1 false, null} ; [ DW_TAG_subprogram ] +!11 = metadata !{i32 281, i32 9, metadata !12, null} +!12 = metadata !{i32 589835, metadata !13, i32 272, i32 5, metadata !1, i32 32} ; [ DW_TAG_lexical_block ] +!13 = metadata !{i32 589835, metadata !14, i32 271, i32 5, metadata !1, i32 31} ; [ DW_TAG_lexical_block ] +!14 = metadata !{i32 589835, metadata !10, i32 267, i32 1, metadata !1, i32 30} ; [ DW_TAG_lexical_block ] +!15 = metadata !{i32 271, i32 5, metadata !14, null} +!16 = metadata !{i32 284, i32 10, metadata !17, null} +!17 = metadata !{i32 589835, metadata !12, i32 282, i32 9, metadata !1, i32 33} ; [ DW_TAG_lexical_block ] +!18 = metadata !{double undef} +!19 = metadata !{i32 590080, metadata !14, metadata !"temp", metadata !1, i32 268, metadata !20, i32 0} ; [ DW_TAG_auto_variable ] +!20 = metadata !{i32 589860, metadata !2, metadata !"double", null, i32 0, i64 64, i64 64, i64 0, i32 0, i32 4} ; [ DW_TAG_base_type ] +!21 = metadata !{i32 286, i32 14, metadata !22, null} +!22 = metadata !{i32 589835, metadata !17, i32 285, i32 13, metadata !1, i32 34} ; [ DW_TAG_lexical_block ] +!23 = metadata !{i32 296, i32 13, metadata !17, null} +!24 = metadata !{i32 313, i32 1, metadata !14, null} -- 2.34.1