From 2744189c46c6e6ab92796de9211d079ff25d4fe5 Mon Sep 17 00:00:00 2001 From: Alex Lorenz Date: Fri, 17 Jul 2015 00:24:15 +0000 Subject: [PATCH] MIR Serialization: Serialize the frame setup machine instruction flag. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@242491 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/MIRParser/MILexer.cpp | 1 + lib/CodeGen/MIRParser/MILexer.h | 1 + lib/CodeGen/MIRParser/MIParser.cpp | 15 ++++--- lib/CodeGen/MIRPrinter.cpp | 4 +- .../MIR/X86/frame-setup-instruction-flag.mir | 39 +++++++++++++++++++ 5 files changed, 54 insertions(+), 6 deletions(-) create mode 100644 test/CodeGen/MIR/X86/frame-setup-instruction-flag.mir diff --git a/lib/CodeGen/MIRParser/MILexer.cpp b/lib/CodeGen/MIRParser/MILexer.cpp index 53c393da45d..6f74838812f 100644 --- a/lib/CodeGen/MIRParser/MILexer.cpp +++ b/lib/CodeGen/MIRParser/MILexer.cpp @@ -73,6 +73,7 @@ static MIToken::TokenKind getIdentifierKind(StringRef Identifier) { .Case("dead", MIToken::kw_dead) .Case("killed", MIToken::kw_killed) .Case("undef", MIToken::kw_undef) + .Case("frame-setup", MIToken::kw_frame_setup) .Default(MIToken::Identifier); } diff --git a/lib/CodeGen/MIRParser/MILexer.h b/lib/CodeGen/MIRParser/MILexer.h index 03b4d486f98..2085eb38f0c 100644 --- a/lib/CodeGen/MIRParser/MILexer.h +++ b/lib/CodeGen/MIRParser/MILexer.h @@ -43,6 +43,7 @@ struct MIToken { kw_dead, kw_killed, kw_undef, + kw_frame_setup, // Identifier tokens Identifier, diff --git a/lib/CodeGen/MIRParser/MIParser.cpp b/lib/CodeGen/MIRParser/MIParser.cpp index b2931189578..3b820c3cdee 100644 --- a/lib/CodeGen/MIRParser/MIParser.cpp +++ b/lib/CodeGen/MIRParser/MIParser.cpp @@ -107,7 +107,7 @@ private: /// instruction name is invalid. bool parseInstrName(StringRef InstrName, unsigned &OpCode); - bool parseInstruction(unsigned &OpCode); + bool parseInstruction(unsigned &OpCode, unsigned &Flags); bool verifyImplicitOperands(ArrayRef Operands, const MCInstrDesc &MCID); @@ -175,11 +175,11 @@ bool MIParser::parse(MachineInstr *&MI) { lex(); } - unsigned OpCode; - if (Token.isError() || parseInstruction(OpCode)) + unsigned OpCode, Flags = 0; + if (Token.isError() || parseInstruction(OpCode, Flags)) return true; - // TODO: Parse the instruction flags and memory operands. + // TODO: Parse the bundle instruction flags and memory operands. // Parse the remaining machine operands. while (Token.isNot(MIToken::Eof)) { @@ -203,6 +203,7 @@ bool MIParser::parse(MachineInstr *&MI) { // TODO: Check for extraneous machine operands. MI = MF.CreateMachineInstr(MCID, DebugLoc(), /*NoImplicit=*/true); + MI->setFlags(Flags); for (const auto &Operand : Operands) MI->addOperand(MF, Operand.Operand); return false; @@ -295,7 +296,11 @@ bool MIParser::verifyImplicitOperands( return false; } -bool MIParser::parseInstruction(unsigned &OpCode) { +bool MIParser::parseInstruction(unsigned &OpCode, unsigned &Flags) { + if (Token.is(MIToken::kw_frame_setup)) { + Flags |= MachineInstr::FrameSetup; + lex(); + } if (Token.isNot(MIToken::Identifier)) return error("expected a machine instruction"); StringRef InstrName = Token.stringValue(); diff --git a/lib/CodeGen/MIRPrinter.cpp b/lib/CodeGen/MIRPrinter.cpp index a701ffdce6a..a1c28bc5697 100644 --- a/lib/CodeGen/MIRPrinter.cpp +++ b/lib/CodeGen/MIRPrinter.cpp @@ -334,8 +334,10 @@ void MIPrinter::print(const MachineInstr &MI) { if (I) OS << " = "; + if (MI.getFlag(MachineInstr::FrameSetup)) + OS << "frame-setup "; OS << TII->getName(MI.getOpcode()); - // TODO: Print the instruction flags, machine mem operands. + // TODO: Print the bundling instruction flags, machine mem operands. if (I < E) OS << ' '; diff --git a/test/CodeGen/MIR/X86/frame-setup-instruction-flag.mir b/test/CodeGen/MIR/X86/frame-setup-instruction-flag.mir new file mode 100644 index 00000000000..ca34fe1050d --- /dev/null +++ b/test/CodeGen/MIR/X86/frame-setup-instruction-flag.mir @@ -0,0 +1,39 @@ +# RUN: llc -march=x86-64 -start-after branch-folder -stop-after branch-folder -o /dev/null %s | FileCheck %s +# This test ensures that the MIR parser parses the frame setup instruction flag. + +--- | + + define i32 @compute(i32 %a) { + body: + %c = mul i32 %a, 11 + ret i32 %c + } + + define i32 @foo(i32 %a) { + entry: + %b = call i32 @compute(i32 %a) + ret i32 %b + } + +... +--- +name: compute +body: + - name: body + id: 0 + instructions: + - '%eax = IMUL32rri8 %edi, 11, implicit-def %eflags' + - 'RETQ %eax' +... +--- +name: foo +body: + - name: entry + id: 0 + instructions: + # CHECK: frame-setup PUSH64r %rax + - 'frame-setup PUSH64r %rax, implicit-def %rsp, implicit %rsp' + - 'CALL64pcrel32 @compute, csr_64, implicit %rsp, implicit %edi, implicit-def %rsp, implicit-def %eax' + - '%rdx = POP64r implicit-def %rsp, implicit %rsp' + - 'RETQ %eax' +... -- 2.34.1