From 2203c92785b64b2df20f0b25e0be6f32a73c18b3 Mon Sep 17 00:00:00 2001 From: Jonathan Kron Date: Wed, 24 Feb 2016 18:36:30 -0800 Subject: [PATCH] Fixing AtomicHashArrayTest ASan Test Failure Summary: Both of these tests will unavoidably fail on ASan because of shared library loads, and indestructable objects. Disabling ASAN testing for these test files. Reviewed By: yfeldblum Differential Revision: D2968169 fb-gh-sync-id: d2acc71b40541af5e10f15d5087a7c07da05453d shipit-source-id: d2acc71b40541af5e10f15d5087a7c07da05453d --- folly/test/AtomicHashArrayTest.cpp | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/folly/test/AtomicHashArrayTest.cpp b/folly/test/AtomicHashArrayTest.cpp index 87abd486..5c3eb70a 100644 --- a/folly/test/AtomicHashArrayTest.cpp +++ b/folly/test/AtomicHashArrayTest.cpp @@ -304,7 +304,10 @@ static bool legalKey(char* a) { TEST(Aha, LookupAny) { auto arr = AHACstrInt::create(12); - arr->insert(std::make_pair(strdup("f"), 42)); + char* f_char = strdup("f"); + SCOPE_EXIT { free(f_char); }; + arr->insert(std::make_pair(f_char, 42)); + EXPECT_EQ(42, arr->find("f")->second); { // Look up a single char, successfully. @@ -331,5 +334,7 @@ TEST(Aha, LookupAny) { EXPECT_TRUE(res.first != arr->end()); } - for (auto it : *arr) free(it.first); + for (auto it : *arr) { + free(it.first); + } } -- 2.34.1