From 22008a548687ea4cf8ef58004a054dbc141161b1 Mon Sep 17 00:00:00 2001 From: Yang Chi Date: Tue, 26 Jul 2016 13:49:40 -0700 Subject: [PATCH] A BufferCallback was created but never deleted in AsyncSocketTest2 Summary: This crashes unit test with asan, since we never deletes it. Reviewed By: djwatson Differential Revision: D3622847 fbshipit-source-id: f7ea7c4f464843353b24a59adefd5d66b95bc169 --- folly/io/async/test/AsyncSocketTest2.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/folly/io/async/test/AsyncSocketTest2.cpp b/folly/io/async/test/AsyncSocketTest2.cpp index f7ca991a..5e548c1e 100644 --- a/folly/io/async/test/AsyncSocketTest2.cpp +++ b/folly/io/async/test/AsyncSocketTest2.cpp @@ -2338,8 +2338,8 @@ TEST(AsyncSocketTest, BufferCallbackKill) { char buf[100 * 1024]; memset(buf, 'c', sizeof(buf)); - BufferCallback* bcb = new BufferCallback; - socket->setBufferCallback(bcb); + BufferCallback bcb; + socket->setBufferCallback(&bcb); WriteCallback wcb; wcb.successCallback = [&] { ASSERT_TRUE(socket.unique()); -- 2.34.1