From 1faea8f0869a173c5952b59fd17718cf42111416 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Sat, 27 Jul 2013 14:14:43 +0000 Subject: [PATCH] DwarfDebug: MD5 is always little endian, bswap on big endian platforms. This makes LLVM emit the same signature regardless of host and target endianess. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@187304 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/CodeGen/AsmPrinter/DwarfDebug.cpp | 5 +++-- test/DebugInfo/{X86 => }/generate-odr-hash.ll | 0 2 files changed, 3 insertions(+), 2 deletions(-) rename test/DebugInfo/{X86 => }/generate-odr-hash.ll (100%) diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp index 0d2d02eba4d..7ba1fc187da 100644 --- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp @@ -1059,8 +1059,9 @@ static void addDIEODRSignature(MD5 &Hash, CompileUnit *CU, DIE *Die) { Hash.final(Result); // ... take the least significant 8 bytes and store those as the attribute. - uint64_t Signature; - memcpy(&Signature, &Result[8], 8); + // Our MD5 implementation always returns its results in little endian, swap + // bytes appropriately. + uint64_t Signature = *reinterpret_cast(Result + 8); // FIXME: This should be added onto the type unit, not the type, but this // works as an intermediate stage. diff --git a/test/DebugInfo/X86/generate-odr-hash.ll b/test/DebugInfo/generate-odr-hash.ll similarity index 100% rename from test/DebugInfo/X86/generate-odr-hash.ll rename to test/DebugInfo/generate-odr-hash.ll -- 2.34.1