From 1fa49a2e4b15c727fdb0715545c44f3aa1108193 Mon Sep 17 00:00:00 2001 From: Adam Simpkins Date: Thu, 26 May 2016 15:38:13 -0700 Subject: [PATCH] move io/Cursor-defs.h to io/Cursor.cpp Summary: The two function definitions in this file are both normal function definitions, not template functions. Therefore this should be just a normal .cpp file, and not a -defs.h header file. Reviewed By: igorsugak Differential Revision: D3348439 fbshipit-source-id: 3ebe49c84493f5aab06c568d9df15a37c2c48836 --- folly/Makefile.am | 1 + folly/io/{Cursor-defs.h => Cursor.cpp} | 2 -- folly/io/test/IOBufCursorBenchmark.cpp | 1 - folly/io/test/IOBufCursorTest.cpp | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) rename folly/io/{Cursor-defs.h => Cursor.cpp} (99%) diff --git a/folly/Makefile.am b/folly/Makefile.am index 1b28ff7f..275d2477 100644 --- a/folly/Makefile.am +++ b/folly/Makefile.am @@ -401,6 +401,7 @@ libfolly_la_SOURCES = \ IPAddressV6.cpp \ LifoSem.cpp \ io/Compression.cpp \ + io/Cursor.cpp \ io/IOBuf.cpp \ io/IOBufQueue.cpp \ io/RecordIO.cpp \ diff --git a/folly/io/Cursor-defs.h b/folly/io/Cursor.cpp similarity index 99% rename from folly/io/Cursor-defs.h rename to folly/io/Cursor.cpp index 078c4297..fe478403 100644 --- a/folly/io/Cursor-defs.h +++ b/folly/io/Cursor.cpp @@ -13,8 +13,6 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -#pragma once - #include #include diff --git a/folly/io/test/IOBufCursorBenchmark.cpp b/folly/io/test/IOBufCursorBenchmark.cpp index 559f7a3e..465691c0 100644 --- a/folly/io/test/IOBufCursorBenchmark.cpp +++ b/folly/io/test/IOBufCursorBenchmark.cpp @@ -20,7 +20,6 @@ #include #include #include -#include DECLARE_bool(benchmark); diff --git a/folly/io/test/IOBufCursorTest.cpp b/folly/io/test/IOBufCursorTest.cpp index 958f6d45..a5bc4eb9 100644 --- a/folly/io/test/IOBufCursorTest.cpp +++ b/folly/io/test/IOBufCursorTest.cpp @@ -19,7 +19,6 @@ #include #include #include -#include #include -- 2.34.1