From 1cf1856408598d785cee4f9439c7671ce458891e Mon Sep 17 00:00:00 2001 From: Sven Over Date: Wed, 27 Apr 2016 06:46:08 -0700 Subject: [PATCH] fix access-after-free bug in ProducerConsumerQueueTest Summary: This bug causes failure when the test is run under ASAN. Reviewed By: meyering Differential Revision: D3229494 fb-gh-sync-id: a43c8332cc45f7892ac86cd0abb799616bca7779 fbshipit-source-id: a43c8332cc45f7892ac86cd0abb799616bca7779 --- folly/test/ProducerConsumerQueueTest.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/folly/test/ProducerConsumerQueueTest.cpp b/folly/test/ProducerConsumerQueueTest.cpp index 903fe91b..d358035a 100644 --- a/folly/test/ProducerConsumerQueueTest.cpp +++ b/folly/test/ProducerConsumerQueueTest.cpp @@ -160,11 +160,11 @@ struct CorrectnessTest { } else { goto again; } + EXPECT_EQ(*data, expect); } else { + EXPECT_EQ(*data, expect); queue_.popFront(); } - - EXPECT_EQ(*data, expect); } } -- 2.34.1