From 16eedf0ba03a751e98f4b57d528344c5fc83e6da Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Wed, 4 Sep 2013 14:12:26 +0000 Subject: [PATCH] Support/Process: Add comments about PageSize and AllocationGranularity on Cygwin and Win32. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@189940 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/Unix/Process.inc | 4 ++-- lib/Support/Windows/Process.inc | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/Support/Unix/Process.inc b/lib/Support/Unix/Process.inc index cd244f69e74..47d0a3c794d 100644 --- a/lib/Support/Unix/Process.inc +++ b/lib/Support/Unix/Process.inc @@ -88,8 +88,8 @@ TimeValue self_process::get_system_time() const { return getRUsageTimes().second; } -// On Cygwin, getpagesize() returns 64k and offset in mmap(3) should be -// aligned to its pagesize. +// On Cygwin, getpagesize() returns 64k(AllocationGranularity) and +// offset in mmap(3) should be aligned to the AllocationGranularity. static unsigned getPageSize() { #if defined(HAVE_GETPAGESIZE) const int page_size = ::getpagesize(); diff --git a/lib/Support/Windows/Process.inc b/lib/Support/Windows/Process.inc index 38d5bc7e119..f840d064d8d 100644 --- a/lib/Support/Windows/Process.inc +++ b/lib/Support/Windows/Process.inc @@ -83,6 +83,8 @@ static unsigned getPageSize() { // that LLVM ought to run as 64-bits on a 64-bit system, anyway. SYSTEM_INFO info; GetSystemInfo(&info); + // FIXME: FileOffset in MapViewOfFile() should be aligned to not dwPageSize, + // but dwAllocationGranularity. return static_cast(info.dwPageSize); } -- 2.34.1