From 138f44b311c1de18d18eddea8ad7f25b93e975e4 Mon Sep 17 00:00:00 2001 From: Wez Furlong Date: Thu, 21 Jul 2016 17:51:38 -0700 Subject: [PATCH] folly: fixup folly::Random FixedSeed test expectations on macOS Summary: uniform_int_distribution is implemented differently on this system and always returns the generated number from our constant random number generator. Reviewed By: yfeldblum Differential Revision: D3585418 fbshipit-source-id: 754076599ba77b49c17f03bb0c92264a3bed4ab0 --- folly/test/RandomTest.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/folly/test/RandomTest.cpp b/folly/test/RandomTest.cpp index cc576ae4..d7c4f4a5 100644 --- a/folly/test/RandomTest.cpp +++ b/folly/test/RandomTest.cpp @@ -65,12 +65,14 @@ TEST(Random, FixedSeed) { // clang-format on ConstantRNG gen; + + // Pick a constant random number... + auto value = Random::rand32(10, gen); + // Loop to make sure it really is constant. for (int i = 0; i < 1024; ++i) { auto result = Random::rand32(10, gen); - // TODO: This is a little bit brittle; standard library changes could break - // it, if it starts implementing distribution types differently. - EXPECT_EQ(0, result); + EXPECT_EQ(value, result); } } -- 2.34.1