From 0fffbafa9609e0e289ff3120ab9e23d244c1dbc0 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Thu, 30 Jul 2009 18:30:19 +0000 Subject: [PATCH] Twine: Use raw_ostream::write_hex, remove unused itohexstr method. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@77617 91177308-0d34-0410-b5e6-96231b3b80d8 --- include/llvm/ADT/Twine.h | 7 ------- lib/Support/Twine.cpp | 3 +-- unittests/ADT/TwineTest.cpp | 3 +-- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/include/llvm/ADT/Twine.h b/include/llvm/ADT/Twine.h index 6c4905e643c..cb5bb4d7b9f 100644 --- a/include/llvm/ADT/Twine.h +++ b/include/llvm/ADT/Twine.h @@ -303,13 +303,6 @@ namespace llvm { return Twine(&Val, UHexKind, 0, EmptyKind); } - // Construct a twine to print \arg Val as an unsigned hexadecimal - // integer. This routine is provided as a convenience to sign extend values - // before printing. - static Twine itohexstr(const int64_t &Val) { - return Twine(&Val, UHexKind, 0, EmptyKind); - } - /// @} /// @name String Operations /// @{ diff --git a/lib/Support/Twine.cpp b/lib/Support/Twine.cpp index 2b0cf062ec8..83a3a6180f3 100644 --- a/lib/Support/Twine.cpp +++ b/lib/Support/Twine.cpp @@ -60,8 +60,7 @@ void Twine::printOneChild(raw_ostream &OS, const void *Ptr, OS << *static_cast(Ptr); break; case Twine::UHexKind: - // FIXME: Add raw_ostream functionality for this. - OS << ::utohexstr(*static_cast(Ptr)); + OS.write_hex(*static_cast(Ptr)); break; } } diff --git a/unittests/ADT/TwineTest.cpp b/unittests/ADT/TwineTest.cpp index 9a31901864e..61e8a0ac37c 100644 --- a/unittests/ADT/TwineTest.cpp +++ b/unittests/ADT/TwineTest.cpp @@ -39,8 +39,7 @@ TEST(TwineTest, Numbers) { EXPECT_EQ("123", Twine((char) 123).str()); EXPECT_EQ("-123", Twine((signed char) -123).str()); - EXPECT_EQ("7B", Twine::utohexstr(123).str()); - EXPECT_EQ("FFFFFFFFFFFFFF85", Twine::itohexstr(-123).str()); + EXPECT_EQ("7b", Twine::utohexstr(123).str()); } TEST(TwineTest, Concat) { -- 2.34.1