From 0d98066a0e8557e9cad2072c48b01d885b0b9125 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 7 Jan 2015 09:30:43 -0800 Subject: [PATCH] folly/stats/BucketedTimeSeries-defs.h: avoid -Wsign-compare error Summary: * folly/stats/BucketedTimeSeries-defs.h (BucketedTimeSeries): Assume that maxDuration is never negative, and cast the signed duration_.count() to size_t, to avoid this error from gcc-4.9: folly/stats/BucketedTimeSeries-defs.h:38:18: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] Test Plan: Run this and note there are fewer errors than before: fbconfig --platform-all=gcc-4.9-glibc-2.20 -r folly && fbmake dbgo Reviewed By: andrei.alexandrescu@fb.com Subscribers: trunkagent, net-systems@, folly-diffs@ FB internal diff: D1770171 Tasks: 5941250 Signature: t1:1770171:1420669115:61e6b8d3248f88b25736322c7066af015209fba5 --- folly/stats/BucketedTimeSeries-defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/stats/BucketedTimeSeries-defs.h b/folly/stats/BucketedTimeSeries-defs.h index aa7786b6..7dacbded 100644 --- a/folly/stats/BucketedTimeSeries-defs.h +++ b/folly/stats/BucketedTimeSeries-defs.h @@ -35,7 +35,7 @@ BucketedTimeSeries::BucketedTimeSeries(size_t nBuckets, // // There is no point in having more buckets than our timestamp // granularity: otherwise we would have buckets that could never be used. - if (nBuckets > duration_.count()) { + if (nBuckets > size_t(duration_.count())) { nBuckets = duration_.count(); } -- 2.34.1