From 09a81a96ea2f9790242675f3c84013266c38d684 Mon Sep 17 00:00:00 2001 From: Joel Marcey Date: Fri, 27 Jun 2014 14:47:54 -0700 Subject: [PATCH] Be explicit about what we're passing to Endian::big Summary: This prevents a linker error on OSX: ``` Undefined symbols for architecture x86_64: "folly::detail::EndianIntBase::swap(unsigned long)", referenced from: __GLOBAL__sub_I_MacAddress.cpp in libfolly.a(MacAddress.cpp.o) ld: symbol(s) not found for architecture x86_64 ``` We need folly and third-party changes in order to land a pull request for HHVM that starts to get FastCGI running on OSX. See the checklist of the HHVM pull request here: https://github.com/facebook/hhvm/pull/2944#issuecomment-47281003 Closes #68 GitHub Author: Daniel Sloof @override-unit-failures Test Plan: fbmake runtests 100% Reviewed By: pt@fb.com, njormrod@fb.com FB internal diff: D1407426 --- folly/MacAddress.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/folly/MacAddress.cpp b/folly/MacAddress.cpp index 6368483f..67934d77 100644 --- a/folly/MacAddress.cpp +++ b/folly/MacAddress.cpp @@ -24,7 +24,7 @@ using std::string; namespace folly { -const MacAddress MacAddress::BROADCAST{Endian::big(0xffffffffffffU)}; +const MacAddress MacAddress::BROADCAST{Endian::big(uint64_t(0xffffffffffffU))}; const MacAddress MacAddress::ZERO; MacAddress::MacAddress(StringPiece str) { -- 2.34.1