From 081bcb0d41f6300b92967b2758e0ba1f23e38462 Mon Sep 17 00:00:00 2001 From: Chris Lattner Date: Sun, 20 Sep 2009 05:18:28 +0000 Subject: [PATCH] Eliminate a masochistic "algorithm" loop, shrinking CommandLine.o from 71524->70700 bytes. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@82366 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/CommandLine.cpp | 21 ++++++++------------- 1 file changed, 8 insertions(+), 13 deletions(-) diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp index e2da198ea7b..228d60a62e0 100644 --- a/lib/Support/CommandLine.cpp +++ b/lib/Support/CommandLine.cpp @@ -1017,14 +1017,6 @@ class HelpPrinter { const Option *EmptyArg; const bool ShowHidden; - // isHidden/isReallyHidden - Predicates to be used to filter down arg lists. - inline static bool isHidden(Option *Opt) { - return Opt->getOptionHiddenFlag() >= Hidden; - } - inline static bool isReallyHidden(Option *Opt) { - return Opt->getOptionHiddenFlag() == ReallyHidden; - } - public: explicit HelpPrinter(bool showHidden) : ShowHidden(showHidden) { EmptyArg = 0; @@ -1043,14 +1035,17 @@ public: std::vector Opts; for (StringMap::iterator I = OptMap.begin(), E = OptMap.end(); I != E; ++I) { + // Ignore really-hidden options. + if (I->second->getOptionHiddenFlag() == ReallyHidden) + continue; + + // Unless showhidden is set, ignore hidden flags. + if (I->second->getOptionHiddenFlag() == Hidden && !ShowHidden) + continue; + Opts.push_back(I->second); } - // Eliminate Hidden or ReallyHidden arguments, depending on ShowHidden - Opts.erase(std::remove_if(Opts.begin(), Opts.end(), - std::ptr_fun(ShowHidden ? isReallyHidden : isHidden)), - Opts.end()); - // Eliminate duplicate entries in table (from enum flags options, f.e.). { // Give OptionSet a scope SmallPtrSet OptionSet; -- 2.34.1