From 07a9641ebf420ae90aa3667ab4df83cd1ade2117 Mon Sep 17 00:00:00 2001 From: Daniel Dunbar Date: Wed, 10 Mar 2010 02:10:29 +0000 Subject: [PATCH] MC/Mach-O: Resolve a FIXME; these relocation types are no longer semanticaly different. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@98120 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/MC/MCAssembler.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/lib/MC/MCAssembler.cpp b/lib/MC/MCAssembler.cpp index b44cd1e6987..00b02e0c6c4 100644 --- a/lib/MC/MCAssembler.cpp +++ b/lib/MC/MCAssembler.cpp @@ -462,9 +462,11 @@ public: llvm_report_error("symbol '" + B->getName() + "' can not be undefined in a subtraction expression"); - // FIXME: This change of type based on the external bit doesn't make much - // sense, it seems to be redundant with the other information in the - // relocation entry. + // Select the appropriate difference relocation type. + // + // Note that there is no longer any semantic difference between these two + // relocation types from the linkers point of view, this is done solely + // for pedantic compatibility with 'as'. Type = A_SD->isExternal() ? RIT_Difference : RIT_LocalDifference; Value2 = B_SD->getFragment()->getAddress() + B_SD->getOffset(); } -- 2.34.1