From 0062f3997237d3344e5a0a440d767eb7b74d1326 Mon Sep 17 00:00:00 2001 From: Alexander Kornienko Date: Mon, 28 Dec 2015 15:46:15 +0000 Subject: [PATCH 1/1] Refactor: Simplify boolean conditional return statements in llvm/lib/Support Summary: Use clang-tidy to simplify boolean conditional return statements Reviewers: rafael, bkramer, ddunbar, Bigcheese, chandlerc, chapuni, nicholas, alexfh Subscribers: alexfh, craig.topper, llvm-commits Patch by Richard Thomson! Differential Revision: http://reviews.llvm.org/D9978 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@256500 91177308-0d34-0410-b5e6-96231b3b80d8 --- lib/Support/CommandLine.cpp | 5 +---- lib/Support/YAMLParser.cpp | 6 ++---- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/lib/Support/CommandLine.cpp b/lib/Support/CommandLine.cpp index c85a387e724..fdcdb03706d 100644 --- a/lib/Support/CommandLine.cpp +++ b/lib/Support/CommandLine.cpp @@ -345,10 +345,7 @@ static bool CommaSeparateAndAddOccurrence(Option *Handler, unsigned pos, Value = Val; } - if (Handler->addOccurrence(pos, ArgName, Value, MultiArg)) - return true; - - return false; + return Handler->addOccurrence(pos, ArgName, Value, MultiArg); } /// ProvideOption - For Value, this differentiates between an empty value ("") diff --git a/lib/Support/YAMLParser.cpp b/lib/Support/YAMLParser.cpp index bb02bbbc5b4..c4384cafff6 100644 --- a/lib/Support/YAMLParser.cpp +++ b/lib/Support/YAMLParser.cpp @@ -962,10 +962,8 @@ void Scanner::skip(uint32_t Distance) { bool Scanner::isBlankOrBreak(StringRef::iterator Position) { if (Position == End) return false; - if ( *Position == ' ' || *Position == '\t' - || *Position == '\r' || *Position == '\n') - return true; - return false; + return *Position == ' ' || *Position == '\t' || *Position == '\r' || + *Position == '\n'; } bool Scanner::consumeLineBreakIfPresent() { -- 2.34.1