Expository comment submitted by Henrik Bach

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18976 91177308-0d34-0410-b5e6-96231b3b80d8

Make %'s a bit more explicit

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18975 91177308-0d34-0410-b5e6-96231b3b80d8

Fix PR485, instead of emitting zero sized arrays, emit arrays of size 1.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18974 91177308-0d34-0410-b5e6-96231b3b80d8

Change the signatures of the destroyFile and destroyDirectory methods to
const because they affect the file system, not the Path object.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18973 91177308-0d34-0410-b5e6-96231b3b80d8

Adjust documentation of GetBytecodeLibraryPaths after removing LLVMGCCDIR
support from it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18972 91177308-0d34-0410-b5e6-96231b3b80d8

Remove LLVMGCCDIR.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18971 91177308-0d34-0410-b5e6-96231b3b80d8

Remove LLVMGCCDIR from the set of defines.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18970 91177308-0d34-0410-b5e6-96231b3b80d8

Remove the CFE's lib directory from the bytecode path because LLVM should
be agnostic to the needs of any specific FE.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18969 91177308-0d34-0410-b5e6-96231b3b80d8

Remove automatic insertion of CFE's lib directory into the bytecode path
because LLVM should be agnostic to the needs of specific front ends.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18968 91177308-0d34-0410-b5e6-96231b3b80d8

Unbreak all archive reading operations introduced by the last patch which
always exited the program with exit code 1 in these cases, regardless of
whether an error occurred or not.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18966 91177308-0d34-0410-b5e6-96231b3b80d8

Add a verifier assertion

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18965 91177308-0d34-0410-b5e6-96231b3b80d8

Eliminate a virtual method call

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18964 91177308-0d34-0410-b5e6-96231b3b80d8

Make archive rules properly depend on llvm-ar.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18963 91177308-0d34-0410-b5e6-96231b3b80d8

Fix a bug in -no-aa that caused two DSGraph tests to XPASS.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18962 91177308-0d34-0410-b5e6-96231b3b80d8

Fix a file overwrite bug in llvm-ar introduced by changes to
createTemporaryFile semantics where it doesn't create a fully unique name
if the basename doesn't exist. This functionality is now optionally
provided by the boolean reuse_current parameter to createTemporaryFile and
makeUnique. The default values differ because of the way these functions
are used in LLVM.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18961 91177308-0d34-0410-b5e6-96231b3b80d8

Disable libprofile as llvm-ar bus errors on it, and I don't want to break
the nightly testers.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18960 91177308-0d34-0410-b5e6-96231b3b80d8

Do not fail an assertion on a broken archive

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18959 91177308-0d34-0410-b5e6-96231b3b80d8

Adjust to new interfaces

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18958 91177308-0d34-0410-b5e6-96231b3b80d8

Adjust to new alias analysis interfaces

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18957 91177308-0d34-0410-b5e6-96231b3b80d8

Make the AliasAnalysis interface more precise for common cases.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18956 91177308-0d34-0410-b5e6-96231b3b80d8

Move virtual method call out of loop

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18955 91177308-0d34-0410-b5e6-96231b3b80d8

Make Win32 TimeValue::toString() re-entrant and work with mingw

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18954 91177308-0d34-0410-b5e6-96231b3b80d8

Fix VC++ compilation errors

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18953 91177308-0d34-0410-b5e6-96231b3b80d8

Don't put newlines in AC macros that can't handle them!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18952 91177308-0d34-0410-b5e6-96231b3b80d8

Change LLVMGCCDIR/bytecode-libs -> LLVMGCCDIR/lib

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18951 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Remove #inclusion of Support/FileUtilities.h which isn't needed any more.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18950 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Convert use of getUniqueFilename to sys::Path::makeUnique();

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18949 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Remove #inclusion of FileUtilities.h, not needed any more.
* Convert getUniqueFilename -> sys::Pat::makeUnique()

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18948 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Fix implementation and documentation about LLVMGCCDIR/bytecode-libs
* Add the makeUnique method, replacement for getUniqueFilename in Support.
* Add the sys::CopyFile function, replacement for CopyFile in Support.
* Move GetLLVMConfigDir() into generic code area since its generic.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18947 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Remove getUniqueFilename and CopyFile. These are now implemented by
sys::Path::makeUnique and sys::CopyFile, respectively.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18946 91177308-0d34-0410-b5e6-96231b3b80d8

Add some system specific functions we use

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18945 91177308-0d34-0410-b5e6-96231b3b80d8

Remove most references to LLVM_LIB_SEARCH_PATH. It now only exists in the
GettingStarted.html document in the environment section and only as an
optional feature.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18944 91177308-0d34-0410-b5e6-96231b3b80d8

Fix the default install directory of modules from / to $(libdir) !

Many thanks to Vladimir Merzliakov for pointing this out!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18942 91177308-0d34-0410-b5e6-96231b3b80d8

Use user time, not wall time, for optimizer time.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18941 91177308-0d34-0410-b5e6-96231b3b80d8

Correct documentation to reflect the change in location of the CFE runtime
libraries. They are now in $CFEINSTALL/lib not $CFEINSTALL/bytecode-lib.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18939 91177308-0d34-0410-b5e6-96231b3b80d8

Constant exprs are not efficiently negatable in practice.  This disables
turning X - (constantexpr) into X + (-constantexpr) among other things.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18935 91177308-0d34-0410-b5e6-96231b3b80d8

Add the getMagicNumber method.
Patch contributed by Henrik Bach. Thanks Henrik!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18933 91177308-0d34-0410-b5e6-96231b3b80d8

The mystery of Olden/tsp solved, and more opportunities for speedup.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18932 91177308-0d34-0410-b5e6-96231b3b80d8

Get rid of shifts by zero in most cases.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18931 91177308-0d34-0410-b5e6-96231b3b80d8

Implement Win32 Path::getStatusInfo(), TimeValue::toString()

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18930 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Change ExecWait calls to sys::Program::ExecuteAndWait
* Convert to use sys::Path where it makes sense

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18929 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Implement the new environment pointer for ExecuteAndWait

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18928 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Remove the ExecWait function. This is now in sys::Program::ExecuteAndWait

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18927 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Fix commentary, wrap lines, etc.
* Add an environment pointer to the ExecuteAndWait function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18926 91177308-0d34-0410-b5e6-96231b3b80d8

Revert the last patch as it causes a static destruction ordering problem.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18925 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Adjust to interface change for FindExecutable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18920 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Adjust to changes in the interface of FindExecutable, getting ToolRunner
ready for bigger things to come.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18919 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Remove isExecutable as its now implemented by sys::Path::executable
* Make FindExecutable a thin veneer over sys::Program::FindProgramByName.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18918 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* isExecutable -> sys::Path::executable()
* Adjust interface of FindExecutable to return a sys::Path

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18917 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
llee was a nice hack, but it wasn't portable so its gone, with Misha's
approval.  Operating systems have facilities available for making bytecode
directly executable without this utility.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18916 91177308-0d34-0410-b5e6-96231b3b80d8

When generating code for X86 targets, make sure the fp control word is set
to 64-bit precision, not 80 bits.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18915 91177308-0d34-0410-b5e6-96231b3b80d8

Minor cleanups

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18914 91177308-0d34-0410-b5e6-96231b3b80d8

Fix link error in PPC optimized build of 'opt'.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18913 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Remove AllocateRWXMemory as it is not used any more in LLVM. The function
has been replaced with sys::Memory::AllocateRWX several months ago.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18912 91177308-0d34-0410-b5e6-96231b3b80d8

Add some notes

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18911 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Remove the MakeFileReadable and MakeFileExecutable functions which are no
longer present in LLVM. They have been replaced with the sys::Path methods
makeReadable and makeExecutable, respectively.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18910 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Replace MakeFileReadable and MakeFileExecutable (from FileUtilities) with
sys::Path::makeReadable and sys::Path:makeExecutable, respectively.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18909 91177308-0d34-0410-b5e6-96231b3b80d8

Get rid of getSizeOf, using ConstantExpr::getSizeOf instead.

do not insert a prototype for malloc of: void* malloc(uint): on 64-bit u
targets this is not correct.  Instead of prototype it as void *malloc(...),
and pass the correct intptr_t through the "...".

Finally, fix Regression/CodeGen/SparcV9/2004-12-13-MallocCrash.ll, by not
forming constantexpr casts from pointer to uint.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18908 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Implement three new functions to allow setting access/permission bits on
the file referenced by a path. The makeReadable and makeExecutable methods
replace the FileUtilities MakeFileReadable and MakeFileExecutable
functions. The makeWritable function is new and provided for consistency
since Path has a writable() method.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18907 91177308-0d34-0410-b5e6-96231b3b80d8

Change this method to return ulong, not uint, for 64-bit targets.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18906 91177308-0d34-0410-b5e6-96231b3b80d8

New testcase that crashes the V9 backend.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18905 91177308-0d34-0410-b5e6-96231b3b80d8

Genericize implementation of GetDLLSuffix now that we have LTDL_SHLIB_EXT
available.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18904 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
The ReadFileIntoAddressSpace and UnmapFileFromAddressSpace functions are no
longer used by LLVM. Remove them. Replacement functionality for both
functions is now encapsulated in the sys::MappedFile class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18903 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
Use sys::MappedFile instead of ReadFileIntoAddressSpace and
UnmapFileFromAddressSpace. sys::MappedFile has the nice property that it
cleans up after itself so exception handling can be removed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18902 91177308-0d34-0410-b5e6-96231b3b80d8

Fix typo.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18901 91177308-0d34-0410-b5e6-96231b3b80d8

Fix this test

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18900 91177308-0d34-0410-b5e6-96231b3b80d8

Add llvm tool variables.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18897 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351:
* Change use of ReadFileIntoAddressSpace to sys::MappedFile use.
* Shorten a line > 80 chars.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18896 91177308-0d34-0410-b5e6-96231b3b80d8

Set the rounding mode for the X86 FPU to 64-bits instead of 80-bits.  We
don't support long double anyway, and this gives us FP results closer to
other targets.

This also speeds up 179.art from 41.4s to 18.32s, by eliminating a problem
with extra precision that causes an FP == comparison to fail (leading to
extra loop iterations).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18895 91177308-0d34-0410-b5e6-96231b3b80d8

Make the loop termination condition clear when building the set of items to
pass to the Linker::LinkInItems function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18894 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351: libLLVMSupport now depends on libLLVMSystem

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18893 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351: \
The getFileTimestamp and getFileSize functions have been removed from  \
FileUtilities.{h,cpp}. They are replaced by Path::getTimestamp and  \
Path::getSize,respectively.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18892 91177308-0d34-0410-b5e6-96231b3b80d8

Added a size_type typedef to LLVM containers to make Visual Studio shut up
(and possibly to make LLVM more x86 64bit friendly).

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18891 91177308-0d34-0410-b5e6-96231b3b80d8

Add a convenience function for clearing the two global areas.
Patch contributed by Morten Ofsted.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18890 91177308-0d34-0410-b5e6-96231b3b80d8

Get rid of some leaks found by VC leak detector.
Patch contributed by Morten Ofsted.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18889 91177308-0d34-0410-b5e6-96231b3b80d8

Minor syntactical change to make this a little easier to comprehend.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18888 91177308-0d34-0410-b5e6-96231b3b80d8

Make use of the new Path inserter function.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18887 91177308-0d34-0410-b5e6-96231b3b80d8

Fix a bug where "." or any single character file name doesn't get the
terminating / when setDirectory is called.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18886 91177308-0d34-0410-b5e6-96231b3b80d8

Remove an always false clause from an if statement.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18885 91177308-0d34-0410-b5e6-96231b3b80d8

Fix a bug where directory names of length one or less where not set
properly (examples: "", ".", "a").

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18883 91177308-0d34-0410-b5e6-96231b3b80d8

Use the new BYTECODE_DESTINATION to override the default bytecode install
destination for this library so that it goes to $(cferuntime_libdir) rather
than just $(libdir). Normal bytecode libraries should be installed in the
$(libdir), but these ones are "special" because they're part of the the
C/C++ front end.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18882 91177308-0d34-0410-b5e6-96231b3b80d8

More properly name bytecode_libdir cferuntime_libdir. This is only the
libdir for the CFE runtime libraries, not "all bytecode".

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18881 91177308-0d34-0410-b5e6-96231b3b80d8

Finish the implementation of the BYTECODE_DESTINATION feature for modules
too and getting rid of the last remnants of bytecode_libdir.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18880 91177308-0d34-0410-b5e6-96231b3b80d8

Implement a new feature, BYTECODE_DESTINATION, to allow a user makefile to
specify where the bytecode library is to be installed. This allows the
default location ($prefix/lib) to be overridden, for special case runtime
libraries like the cfe runtime libs.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18879 91177308-0d34-0410-b5e6-96231b3b80d8

* Add a std::ostream inserter for sys::Path
* Correct the std::string constructor to take a const reference.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18877 91177308-0d34-0410-b5e6-96231b3b80d8

Fix recent breakage of win32 build

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18876 91177308-0d34-0410-b5e6-96231b3b80d8

Make sure the archive doesn't have to exist before we remove it.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18873 91177308-0d34-0410-b5e6-96231b3b80d8

Always remove bytecode archives so that path mismatches don't cause the
contents to not be updated.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18872 91177308-0d34-0410-b5e6-96231b3b80d8

* Fix header block.
* Fix loop style per standards
* Don't create a new Module when the Linker's module is released.
* Add/fix function comments.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18871 91177308-0d34-0410-b5e6-96231b3b80d8

Add missing space in a comment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18870 91177308-0d34-0410-b5e6-96231b3b80d8

Make sure the Archive gets deleted if there's an error.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18869 91177308-0d34-0410-b5e6-96231b3b80d8

Remove commented out functions that have been replaced with lib/System
functionality.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18868 91177308-0d34-0410-b5e6-96231b3b80d8

Fix header and function comments.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18867 91177308-0d34-0410-b5e6-96231b3b80d8

Implement new functions per new interface

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18866 91177308-0d34-0410-b5e6-96231b3b80d8

PR351: \
Use sys::Path not FileUtilities to check file types

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18865 91177308-0d34-0410-b5e6-96231b3b80d8

Convert to use new Linker class interface

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18864 91177308-0d34-0410-b5e6-96231b3b80d8

LinkModules is now in the Linker class

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18863 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351: \
* Remove IsLibrary and GetLibraryPath, replaced by FindLibrary in ../Path.cpp \
* Implement GetSystemLibraryPaths and GetBytecodeLibraryPaths, instead of the \
  GetSystemLibraryPath1 and GetSystemLibraryPath2 methods

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18862 91177308-0d34-0410-b5e6-96231b3b80d8

For PR351: \
* Move generic isArchive method here from Unix/Path.cpp \
* Implement isDynamicLibrary \
* Implement FindLibrary for Linker

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18861 91177308-0d34-0410-b5e6-96231b3b80d8

This file contains basic Linker facilities needed by all tools

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@18860 91177308-0d34-0410-b5e6-96231b3b80d8