oota-llvm.git
10 years agofix polly buildbot
Sebastian Pop [Mon, 10 Mar 2014 21:27:04 +0000 (21:27 +0000)]
fix polly buildbot

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203492 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoIR: Slightly more verbose error in Verifier
Justin Bogner [Mon, 10 Mar 2014 21:22:44 +0000 (21:22 +0000)]
IR: Slightly more verbose error in Verifier

Extend the error message generated by the Verifier when an intrinsic
name does not match the expected mangling to include the expected
name.  Simplifies debugging.

Patch by Philip Reames!

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203490 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMemCpyOpt: When merging memsets also merge the trivial case of two memsets with the...
Benjamin Kramer [Mon, 10 Mar 2014 21:05:13 +0000 (21:05 +0000)]
MemCpyOpt: When merging memsets also merge the trivial case of two memsets with the same destination.

The testcase is from PR19092, but I think the bug described there is actually a clang issue.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203489 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFor functions with ARM target specific calling convention, when simplify-libcall
Evan Cheng [Mon, 10 Mar 2014 20:49:45 +0000 (20:49 +0000)]
For functions with ARM target specific calling convention, when simplify-libcall
optimize a call to a llvm intrinsic to something that invovles a call to a C
library call, make sure it sets the right calling convention on the call.

e.g.
extern double pow(double, double);
double t(double x) {
  return pow(10, x);
}

Compiles to something like this for AAPCS-VFP:
define arm_aapcs_vfpcc double @t(double %x) #0 {
entry:
  %0 = call double @llvm.pow.f64(double 1.000000e+01, double %x)
  ret double %0
}

declare double @llvm.pow.f64(double, double) #1

Simplify libcall (part of instcombine) will turn the above into:
define arm_aapcs_vfpcc double @t(double %x) #0 {
entry:
  %__exp10 = call double @__exp10(double %x) #1
  ret double %__exp10
}

declare double @__exp10(double)

The pre-instcombine code works because calls to LLVM builtins are special.
Instruction selection will chose the right calling convention for the call.
However, the code after instcombine is wrong. The call to __exp10 will use
the C calling convention.

I can think of 3 options to fix this.

1. Make "C" calling convention just work since the target should know what CC
   is being used.

   This doesn't work because each function can use different CC with the "pcs"
   attribute.

2. Have Clang add the right CC keyword on the calls to LLVM builtin.

   This will work but it doesn't match the LLVM IR specification which states
   these are "Standard C Library Intrinsics".

3. Fix simplify libcall so the resulting calls to the C routines will have the
   proper CC keyword. e.g.
   %__exp10 = call arm_aapcs_vfpcc double @__exp10(double %x) #1

   This works and is the solution I implemented here.

Both solutions #2 and #3 would work. After carefully considering the pros and
cons, I decided to implement #3 for the following reasons.

1. It doesn't change the "spec" of the intrinsics.
2. It's a self-contained fix.

There are a couple of potential downsides.
1. There could be other places in the optimizer that is broken in the same way
   that's not addressed by this.
2. There could be other calling conventions that need to be propagated by
   simplify-libcall that's not handled.

But for now, this is the fix that I'm most comfortable with.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203488 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agofix PR13550: add a cmake WITH_POLLY option
Sebastian Pop [Mon, 10 Mar 2014 20:47:39 +0000 (20:47 +0000)]
fix PR13550: add a cmake WITH_POLLY option

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203486 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFollowup to r203483 - add test.
Eli Bendersky [Mon, 10 Mar 2014 20:36:04 +0000 (20:36 +0000)]
Followup to r203483 - add test.

[forgot to 'svn add' before committing r203483]

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203485 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Implement NaCl sandboxing of loads, stores and SP changes:
Sasa Stankovic [Mon, 10 Mar 2014 20:34:23 +0000 (20:34 +0000)]
[mips] Implement NaCl sandboxing of loads, stores and SP changes:

  * Add masking instructions before loads and stores (in MC layer).
  * Add masking instructions after SP changes (in MC layer).
  * Forbid loads, stores and SP changes in delay slots (in MI layer).

Differential Revision: http://llvm-reviews.chandlerc.com/D2904

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203484 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMake sure NVPTX doesn't emit symbol names that aren't valid in PTX.
Eli Bendersky [Mon, 10 Mar 2014 20:05:42 +0000 (20:05 +0000)]
Make sure NVPTX doesn't emit symbol names that aren't valid in PTX.

NVPTX, like the other backends, relies on generic symbol name sanitizing done by
MCSymbol. However, the ptxas assembler is more stringent and disallows some
additional characters in symbol names.

See PR19099 for more details.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203483 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agollvm-c: expose unnamedaddr field of globals
Tim Northover [Mon, 10 Mar 2014 19:24:35 +0000 (19:24 +0000)]
llvm-c: expose unnamedaddr field of globals

Patch by Manuel Jacob.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203482 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDocs: remove paragraph about manual account creation.
Tim Northover [Mon, 10 Mar 2014 19:24:30 +0000 (19:24 +0000)]
Docs: remove paragraph about manual account creation.

There's now a normal UI for that, apparently.

Patch by Manuel Jacob.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203481 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[bugpoint] Add testcase for r203343.
Adam Nemet [Mon, 10 Mar 2014 16:58:54 +0000 (16:58 +0000)]
[bugpoint] Add testcase for r203343.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203472 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd a --enable-clang-plugin-support option to configure.
Rafael Espindola [Mon, 10 Mar 2014 16:58:35 +0000 (16:58 +0000)]
Add a --enable-clang-plugin-support option to configure.

This will replace the now badly named CLANG_IS_PRODUCTION.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203471 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix regression with -O0 for mips .
Reed Kotler [Mon, 10 Mar 2014 16:31:25 +0000 (16:31 +0000)]
Fix regression with -O0 for mips .

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203469 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd test for LinkModules warning on triple, modified by r203009. Datalayout is alread...
JF Bastien [Mon, 10 Mar 2014 15:54:49 +0000 (15:54 +0000)]
Add test for LinkModules warning on triple, modified by r203009. Datalayout is already tested.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203468 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Modernize the IR library a bit.
Benjamin Kramer [Mon, 10 Mar 2014 15:03:06 +0000 (15:03 +0000)]
[C++11] Modernize the IR library a bit.

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203465 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips][fp64] Add an implicit def to MFHC1 claiming that it reads the lower 32-bits...
Daniel Sanders [Mon, 10 Mar 2014 15:01:57 +0000 (15:01 +0000)]
[mips][fp64] Add an implicit def to MFHC1 claiming that it reads the lower 32-bits of 64-bit FPR

Summary:
This is a white lie to workaround a widespread bug in the -mfp64
implementation.

The problem is that none of the 32-bit fpu ops mention the fact that they
clobber the upper 32-bits of the 64-bit FPR. This allows MFHC1 to be
scheduled on the wrong side of most 32-bit FPU ops. Fixing that requires a
major overhaul of the FPU implementation which can't be done right now due to
time constraints.

MFHC1 is one of two affected instructions. These instructions are the only
FPU instructions that don't read or write the lower 32-bits. We therefore
pretend that it reads the bottom 32-bits to artificially create a dependency and
prevent the scheduler changing the behaviour of the code.
The other instruction is MTHC1 which will be fixed once I've have found a failing
test case for it.

The testcase is test-suite/SingleSource/UnitTests/Vector/simple.c when
given TARGET_CFLAGS="-mips32r2 -mfp64 -mmsa".

Reviewers: jacksprat, matheusalmeida

Reviewed By: jacksprat

Differential Revision: http://llvm-reviews.chandlerc.com/D2966

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203464 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemoving llvm::distance and llvm::copy for iterator_range based on post-commit review...
Aaron Ballman [Mon, 10 Mar 2014 13:43:46 +0000 (13:43 +0000)]
Removing llvm::distance and llvm::copy for iterator_range based on post-commit review feedback. Adding an explicit range-based constructor to SmallVector, which supersedes the llvm::copy functionality.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203460 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[mips] Assembly parser must invoke the target streamer to handle .set reorder macro.
Matheus Almeida [Mon, 10 Mar 2014 13:21:10 +0000 (13:21 +0000)]
[mips] Assembly parser must invoke the target streamer to handle .set reorder macro.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203459 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAArch64: fix LowerCONCAT_VECTORS for new CodeGen.
Tim Northover [Mon, 10 Mar 2014 09:34:07 +0000 (09:34 +0000)]
AArch64: fix LowerCONCAT_VECTORS for new CodeGen.

The function was making too many assumptions about its input:

1. The NEON_VDUP optimisation was far too aggressive, assuming (I
think) that the input would always be BUILD_VECTOR.

2. We were treating most unknown concats as legal (by returning Op
rather than SDValue()). I think only concats of pairs of vectors are
actually legal.

http://llvm.org/PR19094

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203450 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Make this call graph a fully regular type by giving it assignment
Chandler Carruth [Mon, 10 Mar 2014 08:08:59 +0000 (08:08 +0000)]
[LCG] Make this call graph a fully regular type by giving it assignment
as well. I don't see any particular need but it imposes no cost to
support it and it makes the API cleaner.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203448 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Make the iterator move constructable (and thus movable in general)
Chandler Carruth [Mon, 10 Mar 2014 08:08:47 +0000 (08:08 +0000)]
[LCG] Make the iterator move constructable (and thus movable in general)
now that there is essentially no cost to doing so. Yay C++11.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203447 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Remove 'virtual' keyword from methods marked with 'override' keyword.
Craig Topper [Mon, 10 Mar 2014 05:29:18 +0000 (05:29 +0000)]
[C++11] Remove 'virtual' keyword from methods marked with 'override' keyword.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203444 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Remove 'virtual' keyword from methods marked with 'override' keyword.
Craig Topper [Mon, 10 Mar 2014 03:53:12 +0000 (03:53 +0000)]
[C++11] Remove 'virtual' keyword from methods marked with 'override' keyword.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203442 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[AArch64] Fix a use of uninitialized memory introduced in r203125,
Chandler Carruth [Mon, 10 Mar 2014 03:52:47 +0000 (03:52 +0000)]
[AArch64] Fix a use of uninitialized memory introduced in r203125,
and caught by the MSan bootstrap build bot. This should hopefully get
the bot green at long last.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203441 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDe-virtualize a method since it doesn't override anything and isn't overridden itself.
Craig Topper [Mon, 10 Mar 2014 03:22:59 +0000 (03:22 +0000)]
De-virtualize a method since it doesn't override anything and isn't overridden itself.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203440 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Mon, 10 Mar 2014 03:19:03 +0000 (03:19 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203439 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] One more formatting fix that I failed to get into the prior
Chandler Carruth [Mon, 10 Mar 2014 02:50:21 +0000 (02:50 +0000)]
[LCG] One more formatting fix that I failed to get into the prior
commit. Sorry for the churn, just trying to keep it out of any
functionality changed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203438 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[TTI] There is actually no realistic way to pop TTI implementations off
Chandler Carruth [Mon, 10 Mar 2014 02:45:14 +0000 (02:45 +0000)]
[TTI] There is actually no realistic way to pop TTI implementations off
the stack of the analysis group because they are all immutable passes.
This is made clear by Craig's recent work to use override
systematically -- we weren't overriding anything for 'finalizePass'
because there is no such thing.

This is kind of a lame restriction on the API -- we can no longer push
and pop things, we just set up the stack and run. However, I'm not
invested in building some better solution on top of the existing
(terrifying) immutable pass and legacy pass manager.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203437 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoADT/PointerIntPairTest.cpp: Appease msc17.
NAKAMURA Takumi [Mon, 10 Mar 2014 02:33:17 +0000 (02:33 +0000)]
ADT/PointerIntPairTest.cpp: Appease msc17.

  - Use constructor instead of initializer list.
  - Disable ManyUnusedBits for now.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203436 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Ran clang-format over this too and it pointed out some fixes.
Chandler Carruth [Mon, 10 Mar 2014 02:14:14 +0000 (02:14 +0000)]
[LCG] Ran clang-format over this too and it pointed out some fixes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203435 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] While I'm here, fix a few other clang-format issues. Pulls some
Chandler Carruth [Mon, 10 Mar 2014 02:12:14 +0000 (02:12 +0000)]
[PM] While I'm here, fix a few other clang-format issues. Pulls some
lines under 80-columns, etc.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203434 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Mon, 10 Mar 2014 02:09:33 +0000 (02:09 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203433 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] Cleanup formatting and namespace commenting. Mostly done with
Chandler Carruth [Mon, 10 Mar 2014 01:42:03 +0000 (01:42 +0000)]
[PM] Cleanup formatting and namespace commenting. Mostly done with
clang-format, but with some modifications by me where it got things
wrong or got confused.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203432 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] As Dave noticed in review, I had erroneously copied the move
Chandler Carruth [Mon, 10 Mar 2014 01:32:25 +0000 (01:32 +0000)]
[PM] As Dave noticed in review, I had erroneously copied the move
constructors from the classes which only have a single reference member
to many other places. This resulted in them copying their single member
instead of moving. =/ Fix this.

There's really not a useful test to add sadly because these move
constructors are only called when something deep inside some standard
library implementation *needs* to move them. Many of the types aren't
even user-impacting types. Or, the objects are copyable anyways and so
the result was merely a performance problem rather than a correctness
problem.

Anyways, thanks for the review. And this is a great example of why
I wish I colud have the compiler write these for me.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203431 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMC: Appease the buildbots
David Majnemer [Mon, 10 Mar 2014 01:04:18 +0000 (01:04 +0000)]
MC: Appease the buildbots

This is fallout from r203429.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203430 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMC: Cleanup MCSectionMachO::ParseSectionSpecifier
David Majnemer [Mon, 10 Mar 2014 00:55:07 +0000 (00:55 +0000)]
MC: Cleanup MCSectionMachO::ParseSectionSpecifier

Split by comma once instead of multiple times.  Moving this upfront
makes the rest of the code considerably simpler.

No functional change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203429 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] Add a comment I missed and add the special members to one more
Chandler Carruth [Mon, 10 Mar 2014 00:54:01 +0000 (00:54 +0000)]
[PM] Add a comment I missed and add the special members to one more
class that might (at some point) need them.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203428 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] Comment on all of the totally pointless definitions of special
Chandler Carruth [Mon, 10 Mar 2014 00:50:56 +0000 (00:50 +0000)]
[PM] Comment on all of the totally pointless definitions of special
members as being te workaround MSVC.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203427 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] I have been educated by several folks that MSVC will never
Chandler Carruth [Mon, 10 Mar 2014 00:35:47 +0000 (00:35 +0000)]
[PM] I have been educated by several folks that MSVC will never
synthesize a move constructor. Thus, for any types where move semantics
are important (yea, that's essentially every type...) you must
explicitly define the special members. Do so systematically throughout
the pass manager as the core of the design relies heavily on move
semantics.

This will hopefully fix the build with MSVC 2013. We still don't know
why MSVC 2012 accepted this code, but it almost certainly wasn't doing
the right thing.

I've also added explicit to a few single-argument constructors spotted
in passing.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203426 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[Sparc] Add support for decoding 'swap' instruction.
Venkatraman Govindaraju [Sun, 9 Mar 2014 23:32:07 +0000 (23:32 +0000)]
[Sparc] Add support for decoding 'swap' instruction.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203424 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix inconsistent whitespace.
Bob Wilson [Sun, 9 Mar 2014 23:17:28 +0000 (23:17 +0000)]
Fix inconsistent whitespace.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203423 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoWork around FreeBSD rtld rpath $ORIGIN limitation
Ed Maste [Sun, 9 Mar 2014 18:48:45 +0000 (18:48 +0000)]
Work around FreeBSD rtld rpath $ORIGIN limitation

FreeBSD's rtld requires the DF_ORIGIN flag set in order to process
$ORIGIN in rpath.

FreeBSD bug http://bugs.freebsd.org/187114

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203419 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sun, 9 Mar 2014 18:03:14 +0000 (18:03 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203418 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoStackColoring: Use range-based for loops.
Benjamin Kramer [Sun, 9 Mar 2014 15:44:45 +0000 (15:44 +0000)]
StackColoring: Use range-based for loops.

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203415 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMachineModuleInfo: Turn nested std::pairs into a proper struct.
Benjamin Kramer [Sun, 9 Mar 2014 15:44:39 +0000 (15:44 +0000)]
MachineModuleInfo: Turn nested std::pairs into a proper struct.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203414 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoSimplifyCFG: Simplify the weight scaling algorithm.
Benjamin Kramer [Sun, 9 Mar 2014 14:42:55 +0000 (14:42 +0000)]
SimplifyCFG: Simplify the weight scaling algorithm.

No change in functionality.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203413 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[LCG] Simplify a bunch of the LCG code with range for loops and auto.
Chandler Carruth [Sun, 9 Mar 2014 12:20:34 +0000 (12:20 +0000)]
[LCG] Simplify a bunch of the LCG code with range for loops and auto.
Still more work to be done here to leverage C++11, but this clears out
the glaring issues.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203395 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add range views for various parts of a Module.
Chandler Carruth [Sun, 9 Mar 2014 12:20:30 +0000 (12:20 +0000)]
[C++11] Add range views for various parts of a Module.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203394 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoChange documentation based on feedback from Chandler.
Ahmed Charles [Sun, 9 Mar 2014 12:12:23 +0000 (12:12 +0000)]
Change documentation based on feedback from Chandler.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203393 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Now that we have C++11 and I've replaced the use of this
Chandler Carruth [Sun, 9 Mar 2014 11:51:11 +0000 (11:51 +0000)]
[C++11] Now that we have C++11 and I've replaced the use of this
horrible smart pointer by std::unique_ptr and strict move semantics, rip
this out.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203392 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[PM] Switch new pass manager from polymorphic_ptr to unique_ptr now that
Chandler Carruth [Sun, 9 Mar 2014 11:49:53 +0000 (11:49 +0000)]
[PM] Switch new pass manager from polymorphic_ptr to unique_ptr now that
it is available. Also make the move semantics sufficiently correct to
tolerate move-only passes, as the PassManagers *are* move-only passes.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203391 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add llvm::make_unique, according to N3656.
Ahmed Charles [Sun, 9 Mar 2014 11:20:17 +0000 (11:20 +0000)]
[C++11] Add llvm::make_unique, according to N3656.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203387 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert r203230, "CodeGenPrep: sink extends of illegal types into use block."
NAKAMURA Takumi [Sun, 9 Mar 2014 11:01:07 +0000 (11:01 +0000)]
Revert r203230, "CodeGenPrep: sink extends of illegal types into use block."

It choked i686 stage2.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203386 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDe-virtualize some methods since they don't override anything.
Craig Topper [Sun, 9 Mar 2014 07:58:15 +0000 (07:58 +0000)]
De-virtualize some methods since they don't override anything.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203379 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sun, 9 Mar 2014 07:44:38 +0000 (07:44 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203378 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoIR: Change inalloca's grammar a bit
David Majnemer [Sun, 9 Mar 2014 06:41:58 +0000 (06:41 +0000)]
IR: Change inalloca's grammar a bit

The grammar for LLVM IR is not well specified in any document but seems
to obey the following rules:

 - Attributes which have parenthesized arguments are never preceded by
   commas.  This form of attribute is the only one which ever has
   optional arguments.  However, not all of these attributes support
   optional arguments: 'thread_local' supports an optional argument but
   'addrspace' does not.  Interestingly, 'addrspace' is documented as
   being a "qualifier".  What constitutes a qualifier?  I cannot find a
   definition.

 - Some attributes use a space between the keyword and the value.
   Examples of this form are 'align' and 'section'.  These are always
   preceded by a comma.

 - Otherwise, the attribute has no argument.  These attributes do not
   have a preceding comma.

Sometimes an attribute goes before the instruction, between the
instruction and it's type, or after it's type.  'atomicrmw' has
'volatile' between the instruction and the type while 'call' has 'tail'
preceding the instruction.

With all this in mind, it seems most consistent for 'inalloca' on an
'inalloca' instruction to occur before between the instruction and the
type.  Unlike the current formulation, there would be no preceding
comma.  The combination 'alloca inalloca' doesn't look particularly
appetizing, perhaps a better spelling of 'inalloca' is down the road.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203376 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "Clean up SmallString a bit"
David Blaikie [Sun, 9 Mar 2014 06:22:58 +0000 (06:22 +0000)]
Revert "Clean up SmallString a bit"

This reverts commit r203374.

Ambiguities in assign... oh well. I'm just going to revert this and
probably not try to recommit it as it's not terribly important.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203375 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoClean up SmallString a bit
David Blaikie [Sun, 9 Mar 2014 06:17:01 +0000 (06:17 +0000)]
Clean up SmallString a bit

Move a common utility (assign(iter, iter)) into SmallVector (some of the
others could be moved there too, but this one seemed particularly
generic) and replace repetitions overrides with using directives.

And simplify SmallVector::assign(num, element) while I'm here rather
than thrashing these files (that cause everyone to rebuild) again.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203374 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Fix break due to MSVC bug.
Ahmed Charles [Sun, 9 Mar 2014 04:57:09 +0000 (04:57 +0000)]
[C++11] Fix break due to MSVC bug.

MSVC (2012, 2013, 2013 Nov CTP) fail on the following code:

int main() {
  int arr[] = {1, 2};
  for (int i : arr)
    do {} while (0);
}

The fix is to put {} around the for loop. I've reported this to the MSVC
team.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203371 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix build break.
Ahmed Charles [Sun, 9 Mar 2014 03:50:36 +0000 (03:50 +0000)]
Fix build break.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203366 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add range based accessors for the Use-Def chain of a Value.
Chandler Carruth [Sun, 9 Mar 2014 03:16:01 +0000 (03:16 +0000)]
[C++11] Add range based accessors for the Use-Def chain of a Value.

This requires a number of steps.
1) Move value_use_iterator into the Value class as an implementation
   detail
2) Change it to actually be a *Use* iterator rather than a *User*
   iterator.
3) Add an adaptor which is a User iterator that always looks through the
   Use to the User.
4) Wrap these in Value::use_iterator and Value::user_iterator typedefs.
5) Add the range adaptors as Value::uses() and Value::users().
6) Update *all* of the callers to correctly distinguish between whether
   they wanted a use_iterator (and to explicitly dig out the User when
   needed), or a user_iterator which makes the Use itself totally
   opaque.

Because #6 requires churning essentially everything that walked the
Use-Def chains, I went ahead and added all of the range adaptors and
switched them to range-based loops where appropriate. Also because the
renaming requires at least churning every line of code, it didn't make
any sense to split these up into multiple commits -- all of which would
touch all of the same lies of code.

The result is still not quite optimal. The Value::use_iterator is a nice
regular iterator, but Value::user_iterator is an iterator over User*s
rather than over the User objects themselves. As a consequence, it fits
a bit awkwardly into the range-based world and it has the weird
extra-dereferencing 'operator->' that so many of our iterators have.
I think this could be fixed by providing something which transforms
a range of T&s into a range of T*s, but that *can* be separated into
another patch, and it isn't yet 100% clear whether this is the right
move.

However, this change gets us most of the benefit and cleans up
a substantial amount of code around Use and User. =]

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203364 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoUpdate comment from r203315 based on review
Adam Nemet [Sat, 8 Mar 2014 21:51:55 +0000 (21:51 +0000)]
Update comment from r203315 based on review

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203361 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdding some includes to appease build bots. Amends r203354
Aaron Ballman [Sat, 8 Mar 2014 20:15:31 +0000 (20:15 +0000)]
Adding some includes to appease build bots. Amends r203354

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203356 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdding range-based STL-like helper APIs. llvm::distance() is the range version of...
Aaron Ballman [Sat, 8 Mar 2014 20:11:24 +0000 (20:11 +0000)]
Adding range-based STL-like helper APIs. llvm::distance() is the range version of std::distance. llvm::copy is the range version of std::copy.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203354 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMake createObjectImage and createObjectImageFromFile static methods on the
Lang Hames [Sat, 8 Mar 2014 18:45:12 +0000 (18:45 +0000)]
Make createObjectImage and createObjectImageFromFile static methods on the
relevant subclasses of RuntimeDyldImpl. This allows construction of
RuntimeDyldImpl instances to be deferred until after the target architecture is
known.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203352 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoChange else if => if after return, after r203265
Duncan P. N. Exon Smith [Sat, 8 Mar 2014 15:15:42 +0000 (15:15 +0000)]
Change else if => if after return, after r203265

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203347 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix 80 cols.
Ahmed Charles [Sat, 8 Mar 2014 12:51:31 +0000 (12:51 +0000)]
Fix 80 cols.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203346 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sat, 8 Mar 2014 08:27:28 +0000 (08:27 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203345 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sat, 8 Mar 2014 07:51:20 +0000 (07:51 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203344 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[bugpoint] Don't ignore arg in -compile-commad="tool arg"
Adam Nemet [Sat, 8 Mar 2014 07:48:19 +0000 (07:48 +0000)]
[bugpoint] Don't ignore arg in -compile-commad="tool arg"

Args is an output parameter of the function lexCommand but the reference
operator was missed.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203343 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sat, 8 Mar 2014 07:14:16 +0000 (07:14 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203342 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDe-virtualize a method since it doesn't override anything (yay 'override' keyword...
Craig Topper [Sat, 8 Mar 2014 07:07:08 +0000 (07:07 +0000)]
De-virtualize a method since it doesn't override anything (yay 'override' keyword) and its class is in an anonymous namespace.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203341 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sat, 8 Mar 2014 07:02:02 +0000 (07:02 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203340 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Add 'override' keyword to virtual methods that override their base class.
Craig Topper [Sat, 8 Mar 2014 06:31:39 +0000 (06:31 +0000)]
[C++11] Add 'override' keyword to virtual methods that override their base class.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203339 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: further improvements to test following up on r203329
David Blaikie [Sat, 8 Mar 2014 02:45:53 +0000 (02:45 +0000)]
DebugInfo: further improvements to test following up on r203329

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203337 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Fix test fallout from r203323
David Blaikie [Sat, 8 Mar 2014 01:32:51 +0000 (01:32 +0000)]
DebugInfo: Fix test fallout from r203323

Will fix this harder in a moment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203329 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Use DW_FORM_data4 for DW_AT_high_pc in DW_TAG_lexical_blocks
David Blaikie [Sat, 8 Mar 2014 00:58:20 +0000 (00:58 +0000)]
DebugInfo: Use DW_FORM_data4 for DW_AT_high_pc in DW_TAG_lexical_blocks

Suggested by Adrian Prantl in code review for r203187

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203323 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd support for hashing location information for CU level hashes.
Eric Christopher [Sat, 8 Mar 2014 00:29:41 +0000 (00:29 +0000)]
Add support for hashing location information for CU level hashes.
Add a testcase based on sret.cpp where we can now hash the entire
compile unit.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203319 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[DAGCombiner] Distribute TRUNC through AND in rotation amount
Adam Nemet [Fri, 7 Mar 2014 23:56:30 +0000 (23:56 +0000)]
[DAGCombiner] Distribute TRUNC through AND in rotation amount

This is already done for shifts.  Allow it for rotations as well. E.g.:

   (rotl:i32 x, (trunc (and y, 31))) -> (rotl:i32 x, (and (trunc y), 31))

Use the newly factored-out distributeTruncateThroughAnd.

With this patch and some X86.td tweaks we should be able to remove redundant
masking of the rotation amount like in the example above.  HW implicitly
performs this masking.

The testcase will be added as part of the X86 patch.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203316 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[DAGCombiner] Recognize another rotation idiom
Adam Nemet [Fri, 7 Mar 2014 23:56:28 +0000 (23:56 +0000)]
[DAGCombiner] Recognize another rotation idiom

This is the new idiom:

  x<<(y&31) | x>>((0-y)&31)

which is recognized as:

  x ROTL (y&31)

The change refines matchRotateSub.  In
Neg & (OpSize - 1) == (OpSize - Pos) & (OpSize - 1), if Pos is
Pos' & (OpSize - 1) we can just use Pos' instead of Pos.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203315 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[DAGCombiner] Slightly improve readability of matchRotateSub
Adam Nemet [Fri, 7 Mar 2014 23:56:24 +0000 (23:56 +0000)]
[DAGCombiner] Slightly improve readability of matchRotateSub

Slightly change the wording in the function comment. Originally, it can be
misunderstood as we turned the input into two subsequent rotates.

Better connect the comment which talks about Mask and the code which used
LoBits.  Renamed variable to MaskLoBits.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203314 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoISel: Make VSELECT selection terminate in cases where the condition type has to
Arnold Schwaighofer [Fri, 7 Mar 2014 23:25:55 +0000 (23:25 +0000)]
ISel: Make VSELECT selection terminate in cases where the condition type has to
be split and the result type widened.

When the condition of a vselect has to be split it makes no sense widening the
vselect and thereby widening the condition. We end up in an endless loop of
widening (vselect result type) and splitting (condition mask type) doing this.
Instead, split both the condition and the vselect and widen the result.

I ran this over the test suite with i686 and mattr=+sse and saw no regressions.

Fixes PR18036.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203311 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove unnecessary test for Darwin and update testcase to be a little less
Adrian Prantl [Fri, 7 Mar 2014 23:07:21 +0000 (23:07 +0000)]
Remove unnecessary test for Darwin and update testcase to be a little less
horrible/fragile.
rdar://problem/16264854

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203309 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd a virtual destructor to quiet a warning.
Eric Christopher [Fri, 7 Mar 2014 22:53:36 +0000 (22:53 +0000)]
Add a virtual destructor to quiet a warning.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203307 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRange-ify some for loops.
Owen Anderson [Fri, 7 Mar 2014 22:48:22 +0000 (22:48 +0000)]
Range-ify some for loops.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203306 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoActually add the header file.
Eric Christopher [Fri, 7 Mar 2014 22:43:09 +0000 (22:43 +0000)]
Actually add the header file.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203305 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoTwo part patch:
Eric Christopher [Fri, 7 Mar 2014 22:40:37 +0000 (22:40 +0000)]
Two part patch:

First: refactor out the emission of entries into the .debug_loc section
into its own routine.

Second: add a new class ByteStreamer that can be used to either emit
using an AsmPrinter or hash using DIEHash the series of bytes that
would be emitted. Use this in all of the location emission routines
for the .debug_loc section.

No functional change intended outside of a few additional comments
in verbose assembly.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203304 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoAdd include guards and make public a few routines that add values
Eric Christopher [Fri, 7 Mar 2014 22:40:30 +0000 (22:40 +0000)]
Add include guards and make public a few routines that add values
to the hash.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203303 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove unused method declaration
Eli Bendersky [Fri, 7 Mar 2014 22:19:10 +0000 (22:19 +0000)]
Remove unused method declaration

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203301 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRevert "Remove unnecessary check for Darwin. rdar://problem/16264854"
Adrian Prantl [Fri, 7 Mar 2014 22:18:23 +0000 (22:18 +0000)]
Revert "Remove unnecessary check for Darwin. rdar://problem/16264854"

This breaks linux buildbots. Go figure.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203300 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoMoved test file from test/MC/Mips to test/CodeGen/Mips.
Sasa Stankovic [Fri, 7 Mar 2014 22:08:46 +0000 (22:08 +0000)]
Moved test file from test/MC/Mips to test/CodeGen/Mips.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203298 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoRemove unnecessary check for Darwin. rdar://problem/16264854
Adrian Prantl [Fri, 7 Mar 2014 22:04:42 +0000 (22:04 +0000)]
Remove unnecessary check for Darwin. rdar://problem/16264854

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203297 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Use DW_FORM_data4 for DW_AT_high_pc in inlined functions
David Blaikie [Fri, 7 Mar 2014 22:00:56 +0000 (22:00 +0000)]
DebugInfo: Use DW_FORM_data4 for DW_AT_high_pc in inlined functions

Suggested by Adrian Prantl in code review for r203187.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203296 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoDebugInfo: Update test to cover linux (with a FIXME...) too
David Blaikie [Fri, 7 Mar 2014 22:00:49 +0000 (22:00 +0000)]
DebugInfo: Update test to cover linux (with a FIXME...) too

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203295 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Revert uses of lambdas with array_pod_sort.
Benjamin Kramer [Fri, 7 Mar 2014 21:52:38 +0000 (21:52 +0000)]
[C++11] Revert uses of lambdas with array_pod_sort.

Looks like GCC implements the lambda->function pointer conversion differently.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203294 91177308-0d34-0410-b5e6-96231b3b80d8

10 years ago[C++11] Convert sort predicates into lambdas.
Benjamin Kramer [Fri, 7 Mar 2014 21:35:39 +0000 (21:35 +0000)]
[C++11] Convert sort predicates into lambdas.

No functionality change.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203288 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoActually include the ArrayRef header rather than rely on the forward
Eric Christopher [Fri, 7 Mar 2014 21:30:49 +0000 (21:30 +0000)]
Actually include the ArrayRef header rather than rely on the forward
declaration.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203287 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix up formatting.
Eric Christopher [Fri, 7 Mar 2014 21:27:42 +0000 (21:27 +0000)]
Fix up formatting.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203286 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoFix EXPECT_* to not produce a compile warning.
Eli Bendersky [Fri, 7 Mar 2014 21:04:24 +0000 (21:04 +0000)]
Fix EXPECT_* to not produce a compile warning.

EXPECT_TRUE/FALSE is also more idiomatic for booleans than EXPECT_EQ

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203284 91177308-0d34-0410-b5e6-96231b3b80d8

10 years agoR600/SI: Using SGPRs is illegal for instructions that read carry-out from VCC
Tom Stellard [Fri, 7 Mar 2014 20:12:39 +0000 (20:12 +0000)]
R600/SI: Using SGPRs is illegal for instructions that read carry-out from VCC

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@203281 91177308-0d34-0410-b5e6-96231b3b80d8