From: Brian Gaeke Date: Sat, 22 Nov 2003 07:18:25 +0000 (+0000) Subject: Support constant casting constant pointers to ints/uints, and/or X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=f9c86cf5cf3f7af65bbcb2e40d44903380d642e9;p=oota-llvm.git Support constant casting constant pointers to ints/uints, and/or the other way around, instead of failing a large, tumor-like assertion. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@10171 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/Printer.cpp b/lib/Target/X86/Printer.cpp index 292a465e725..bf90064d2dc 100644 --- a/lib/Target/X86/Printer.cpp +++ b/lib/Target/X86/Printer.cpp @@ -185,15 +185,19 @@ void Printer::emitConstantValueOnly(const Constant *CV) { } case Instruction::Cast: { // Support only non-converting or widening casts for now, that is, ones - // that do not involve a change in value. This assertion is not a - // complete check. + // that do not involve a change in value. This assertion is really gross, + // and may not even be a complete check. Constant *Op = CE->getOperand(0); const Type *OpTy = Op->getType(), *Ty = CE->getType(); + // Remember, kids, pointers on x86 can be losslessly converted back and + // forth into 32-bit or wider integers, regardless of signedness. :-P assert(((isa(OpTy) - && (Ty == Type::LongTy || Ty == Type::ULongTy)) + && (Ty == Type::LongTy || Ty == Type::ULongTy + || Ty == Type::IntTy || Ty == Type::UIntTy)) || (isa(Ty) - && (OpTy == Type::LongTy || OpTy == Type::ULongTy)) + && (OpTy == Type::LongTy || OpTy == Type::ULongTy + || OpTy == Type::IntTy || OpTy == Type::UIntTy)) || (((TD.getTypeSize(Ty) >= TD.getTypeSize(OpTy)) && OpTy->isLosslesslyConvertibleTo(Ty)))) && "FIXME: Don't yet support this kind of constant cast expr"); diff --git a/lib/Target/X86/X86AsmPrinter.cpp b/lib/Target/X86/X86AsmPrinter.cpp index 292a465e725..bf90064d2dc 100644 --- a/lib/Target/X86/X86AsmPrinter.cpp +++ b/lib/Target/X86/X86AsmPrinter.cpp @@ -185,15 +185,19 @@ void Printer::emitConstantValueOnly(const Constant *CV) { } case Instruction::Cast: { // Support only non-converting or widening casts for now, that is, ones - // that do not involve a change in value. This assertion is not a - // complete check. + // that do not involve a change in value. This assertion is really gross, + // and may not even be a complete check. Constant *Op = CE->getOperand(0); const Type *OpTy = Op->getType(), *Ty = CE->getType(); + // Remember, kids, pointers on x86 can be losslessly converted back and + // forth into 32-bit or wider integers, regardless of signedness. :-P assert(((isa(OpTy) - && (Ty == Type::LongTy || Ty == Type::ULongTy)) + && (Ty == Type::LongTy || Ty == Type::ULongTy + || Ty == Type::IntTy || Ty == Type::UIntTy)) || (isa(Ty) - && (OpTy == Type::LongTy || OpTy == Type::ULongTy)) + && (OpTy == Type::LongTy || OpTy == Type::ULongTy + || OpTy == Type::IntTy || OpTy == Type::UIntTy)) || (((TD.getTypeSize(Ty) >= TD.getTypeSize(OpTy)) && OpTy->isLosslesslyConvertibleTo(Ty)))) && "FIXME: Don't yet support this kind of constant cast expr");