From: Anton Korobeynikov Date: Thu, 3 Jul 2008 07:43:14 +0000 (+0000) Subject: llvm-gcc sometimes marks external declarations hidden, because intializers are X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=f550f472ee0a9717f70c78ac422c04e252dbeec9;p=oota-llvm.git llvm-gcc sometimes marks external declarations hidden, because intializers are processed separately. Honour such situation and emit PIC relocations properly in such case. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@53091 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86Subtarget.cpp b/lib/Target/X86/X86Subtarget.cpp index b4c58496961..fa630edb389 100644 --- a/lib/Target/X86/X86Subtarget.cpp +++ b/lib/Target/X86/X86Subtarget.cpp @@ -47,7 +47,8 @@ bool X86Subtarget::GVRequiresExtraLoad(const GlobalValue* GV, // Extra load is needed for all externally visible. if (isDirectCall) return false; - if (GV->hasInternalLinkage() || GV->hasHiddenVisibility()) + if (GV->hasInternalLinkage() || + (GV->hasHiddenVisibility() && !GV->isDeclaration())) return false; return true; } else if (isTargetCygMing() || isTargetWindows()) {