From: Owen Anderson Date: Wed, 9 Jul 2008 21:15:10 +0000 (+0000) Subject: Don't use an expensive check for two-address-ness when we have the information sittin... X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=dd4b47c9b27eec402b56b27159c4323dd9aa5e94;p=oota-llvm.git Don't use an expensive check for two-address-ness when we have the information sitting around to determine it much more quickly, This speeds up the local register allocator from 0.37s to 0.31s on instcombine. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@53359 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/RegAllocLocal.cpp b/lib/CodeGen/RegAllocLocal.cpp index 9063e6de936..3e1038daa9c 100644 --- a/lib/CodeGen/RegAllocLocal.cpp +++ b/lib/CodeGen/RegAllocLocal.cpp @@ -585,13 +585,24 @@ void RALocal::ComputeLocalLiveness(MachineBasicBlock& MBB) { // Defs others than 2-addr redefs _do_ trigger flag changes: // - A def followed by a def is dead // - A use followed by a def is a kill - if (MO.isReg() && MO.getReg() && MO.isDef() && - !I->isRegReDefinedByTwoAddr(MO.getReg())) { + if (MO.isReg() && MO.getReg() && MO.isDef()) { std::map >::iterator last = LastUseDef.find(MO.getReg()); if (last != LastUseDef.end()) { + + // If this is a two address instr, then we don't mark the def + // as killing the use. + if (last->second.first == I && + I->getDesc().getOperandConstraint(last->second.second, + TOI::TIED_TO) == (signed)i) { + LastUseDef[MO.getReg()] = std::make_pair(I, i); + continue; + } + + MachineOperand& lastUD = last->second.first->getOperand(last->second.second); + if (lastUD.isDef()) lastUD.setIsDead(true); else if (lastUD.isUse())