From: Rafael Espindola Date: Mon, 2 Jun 2008 07:52:43 +0000 (+0000) Subject: Don't use the GOT for symbols that are not externally visible. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=da5860fa8b8ad7f8622fc096a55d68a140c7c3ac;p=oota-llvm.git Don't use the GOT for symbols that are not externally visible. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@51865 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Target/X86/X86Subtarget.cpp b/lib/Target/X86/X86Subtarget.cpp index 23ceb9ba966..b4c58496961 100644 --- a/lib/Target/X86/X86Subtarget.cpp +++ b/lib/Target/X86/X86Subtarget.cpp @@ -44,9 +44,12 @@ bool X86Subtarget::GVRequiresExtraLoad(const GlobalValue* GV, GV->hasCommonLinkage() || (GV->isDeclaration() && !GV->hasNotBeenReadFromBitcode()))); } else if (isTargetELF()) { - // Extra load is needed for all non-statics. - return (!isDirectCall && - (GV->isDeclaration() || !GV->hasInternalLinkage())); + // Extra load is needed for all externally visible. + if (isDirectCall) + return false; + if (GV->hasInternalLinkage() || GV->hasHiddenVisibility()) + return false; + return true; } else if (isTargetCygMing() || isTargetWindows()) { return (GV->hasDLLImportLinkage()); }