From: Chris Metcalf <cmetcalf@tilera.com>
Date: Mon, 1 Nov 2010 19:25:16 +0000 (-0400)
Subject: arch/tile: avoid __must_check warning on one strict_strtol check
X-Git-Tag: firefly_0821_release~7613^2~3352^2~8
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=d59e609d6568ba5ab23c256f412ac5ec360722c1;p=firefly-linux-kernel-4.4.55.git

arch/tile: avoid __must_check warning on one strict_strtol check

For the "initfree" boot argument it's not that big a deal, but
to avoid warnings in the code, we check for a valid value before
allowing the specified argument to override the kernel default.

Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
---

diff --git a/arch/tile/mm/init.c b/arch/tile/mm/init.c
index 78e1982cb6c9..0b9ce69b0ee5 100644
--- a/arch/tile/mm/init.c
+++ b/arch/tile/mm/init.c
@@ -988,8 +988,12 @@ static long __write_once initfree = 1;
 /* Select whether to free (1) or mark unusable (0) the __init pages. */
 static int __init set_initfree(char *str)
 {
-	strict_strtol(str, 0, &initfree);
-	pr_info("initfree: %s free init pages\n", initfree ? "will" : "won't");
+	long val;
+	if (strict_strtol(str, 0, &val)) {
+		initfree = val;
+		pr_info("initfree: %s free init pages\n",
+			initfree ? "will" : "won't");
+	}
 	return 1;
 }
 __setup("initfree=", set_initfree);