From: Christopher Dykes <cdykes@fb.com>
Date: Thu, 2 Mar 2017 21:44:59 +0000 (-0800)
Subject: Revert D4618623: Give observer manager threads a name
X-Git-Tag: v2017.03.06.00~5
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=c9cbfdb7254cef993316a53e8ad11e8cf1c6f33f;p=folly.git

Revert D4618623: Give observer manager threads a name

Summary: This reverts commit 21b86944f513da0700039a3e3736937fd72e8887

Differential Revision: D4618623

fbshipit-source-id: 6ab6498a2ce22895d7052e258d1af216d46ca178
---

diff --git a/folly/experimental/observer/detail/ObserverManager.cpp b/folly/experimental/observer/detail/ObserverManager.cpp
index aea3eec0..f14b9092 100644
--- a/folly/experimental/observer/detail/ObserverManager.cpp
+++ b/folly/experimental/observer/detail/ObserverManager.cpp
@@ -16,11 +16,8 @@
 #include <folly/experimental/observer/detail/ObserverManager.h>
 
 #include <folly/ExceptionString.h>
-#include <folly/FixedString.h>
-#include <folly/Format.h>
 #include <folly/MPMCQueue.h>
 #include <folly/Singleton.h>
-#include <folly/ThreadName.h>
 #include <folly/portability/GFlags.h>
 
 namespace folly {
@@ -35,9 +32,6 @@ DEFINE_int32(
     4,
     "How many internal threads ObserverManager should use");
 
-static constexpr auto kObserverManagerThreadNamePrefix =
-    folly::makeFixedString("ObserverMngr");
-
 namespace {
 constexpr size_t kCurrentQueueSize{10 * 1024};
 constexpr size_t kNextQueueSize{10 * 1024};
@@ -51,9 +45,7 @@ class ObserverManager::CurrentQueue {
       FLAGS_observer_manager_pool_size = 1;
     }
     for (int32_t i = 0; i < FLAGS_observer_manager_pool_size; ++i) {
-      threads_.emplace_back([this, i]() {
-        folly::setThreadName(
-            folly::sformat("{}{}", kObserverManagerThreadNamePrefix, i));
+      threads_.emplace_back([&]() {
         ObserverManager::inManagerThread_ = true;
 
         while (true) {