From: Dan Carpenter Date: Tue, 13 Oct 2015 07:09:19 +0000 (+0300) Subject: ASoC: wm8960: harmless underflow in wm8960_put_deemph() X-Git-Tag: firefly_0821_release~176^2~581^2~9^2^4~1^4 X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=c1fe81f2cd30c18d7df444697bac8051fdf2aee6;p=firefly-linux-kernel-4.4.55.git ASoC: wm8960: harmless underflow in wm8960_put_deemph() We should only accept "deemph" values of zero and one, but by mistake we accept negatives as well. It's harmless but let's clean it up anyway. Signed-off-by: Dan Carpenter Acked-by: Charles Keepax Signed-off-by: Mark Brown --- diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index e3b7d0c57411..dc47c2fa6622 100644 --- a/sound/soc/codecs/wm8960.c +++ b/sound/soc/codecs/wm8960.c @@ -201,7 +201,7 @@ static int wm8960_put_deemph(struct snd_kcontrol *kcontrol, { struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol); struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec); - int deemph = ucontrol->value.integer.value[0]; + unsigned int deemph = ucontrol->value.integer.value[0]; if (deemph > 1) return -EINVAL;