From: Yedidya Feldblum <yfeldblum@fb.com>
Date: Wed, 7 Oct 2015 05:22:49 +0000 (-0700)
Subject: Remove evil using statements from AsyncSSLSocket.h
X-Git-Tag: deprecate-dynamic-initializer~351
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=c12818f97b2317525abd3ef8e0ad23416cde6c8b;p=folly.git

Remove evil using statements from AsyncSSLSocket.h

Summary: [Folly] Remove evil `using` statements from `AsyncSSLSocket.h`.

`using` in headers is frowned upon.

Consider this diff a frown.

Reviewed By: @alandau

Differential Revision: D2509810

fb-gh-sync-id: 4a752b9f4a5be6ac4ca7c498c0168ffad5c35d7f
---

diff --git a/folly/io/async/AsyncSSLSocket.h b/folly/io/async/AsyncSSLSocket.h
index dd328703..4b8e4773 100644
--- a/folly/io/async/AsyncSSLSocket.h
+++ b/folly/io/async/AsyncSSLSocket.h
@@ -31,9 +31,6 @@
 #include <folly/io/IOBuf.h>
 #include <folly/io/Cursor.h>
 
-using folly::io::Cursor;
-using std::unique_ptr;
-
 namespace folly {
 
 class SSLException: public folly::AsyncSocketException {
@@ -862,7 +859,7 @@ class AsyncSSLSocket : public virtual AsyncSocket {
   static int sslVerifyCallback(int preverifyOk, X509_STORE_CTX* ctx);
 
   bool parseClientHello_{false};
-  unique_ptr<ClientHelloInfo> clientHelloInfo_;
+  std::unique_ptr<ClientHelloInfo> clientHelloInfo_;
 };
 
 } // namespace