From: Hal Finkel Date: Tue, 9 Jul 2013 18:55:10 +0000 (+0000) Subject: WidenVecRes_BUILD_VECTOR must use the first operand's type X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=b9c8c40acbe120ebf44d2a81382ceee100bcd331;p=oota-llvm.git WidenVecRes_BUILD_VECTOR must use the first operand's type Because integer BUILD_VECTOR operands may have a larger type than the result's vector element type, and all operands must have the same type, when widening a BUILD_VECTOR node by adding UNDEFs, we cannot use the vector element type, but rather must use the type of the existing operands. Another bug found by llvm-stress. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@185960 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp b/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp index 2a5d7216a97..2cd59ac0814 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp @@ -1872,7 +1872,10 @@ SDValue DAGTypeLegalizer::WidenVecRes_BUILD_VECTOR(SDNode *N) { SDLoc dl(N); // Build a vector with undefined for the new nodes. EVT VT = N->getValueType(0); - EVT EltVT = VT.getVectorElementType(); + + // Integer BUILD_VECTOR operands may be larger than the node's vector element + // type. The UNDEFs need to have the same type as the existing operands. + EVT EltVT = N->getOperand(0).getValueType(); unsigned NumElts = VT.getVectorNumElements(); EVT WidenVT = TLI.getTypeToTransformTo(*DAG.getContext(), VT); diff --git a/test/CodeGen/PowerPC/bv-widen-undef.ll b/test/CodeGen/PowerPC/bv-widen-undef.ll new file mode 100644 index 00000000000..9e58f0d9502 --- /dev/null +++ b/test/CodeGen/PowerPC/bv-widen-undef.ll @@ -0,0 +1,23 @@ +; RUN: llc -mtriple=powerpc64-unknown-linux-gnu -mcpu=pwr7 < %s +target triple = "powerpc64-unknown-linux-gnu" + +define void @autogen_SD4357(i8) { +BB: + br label %CF + +CF: ; preds = %CF, %BB + br i1 undef, label %CF, label %CF77 + +CF77: ; preds = %CF81, %CF77, %CF + %Shuff12 = shufflevector <2 x i8> , <2 x i8> , <2 x i32> + br i1 undef, label %CF77, label %CF80 + +CF80: ; preds = %CF80, %CF77 + %B21 = mul <2 x i8> %Shuff12, + %Cmp24 = fcmp une ppc_fp128 0xM00000000000000000000000000000000, 0xM00000000000000000000000000000000 + br i1 %Cmp24, label %CF80, label %CF81 + +CF81: ; preds = %CF80 + %I36 = insertelement <2 x i8> %B21, i8 %0, i32 0 + br label %CF77 +}