From: Tvrtko Ursulin Date: Thu, 15 Jul 2010 12:25:06 +0000 (+0100) Subject: securityfs: Drop dentry reference count when mknod fails X-Git-Tag: firefly_0821_release~9833^2~1319^2~35 X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=b8bc83ab4dcbc9938b95a90bbb50d89d1904d5ab;p=firefly-linux-kernel-4.4.55.git securityfs: Drop dentry reference count when mknod fails lookup_one_len increments dentry reference count which is not decremented when the create operation fails. This can cause a kernel BUG at fs/dcache.c:676 at unmount time. Also error code returned when new_inode() fails was replaced with more appropriate -ENOMEM. Signed-off-by: Tvrtko Ursulin Acked-by: Serge E. Hallyn Acked-by: Greg Kroah-Hartman Signed-off-by: James Morris --- diff --git a/security/inode.c b/security/inode.c index 1c812e874504..8c777f022ad1 100644 --- a/security/inode.c +++ b/security/inode.c @@ -86,7 +86,7 @@ static int mknod(struct inode *dir, struct dentry *dentry, int mode, dev_t dev) { struct inode *inode; - int error = -EPERM; + int error = -ENOMEM; if (dentry->d_inode) return -EEXIST; @@ -166,6 +166,8 @@ static int create_by_name(const char *name, mode_t mode, error = mkdir(parent->d_inode, *dentry, mode); else error = create(parent->d_inode, *dentry, mode); + if (error) + dput(*dentry); } else error = PTR_ERR(*dentry); mutex_unlock(&parent->d_inode->i_mutex);