From: Chris Lattner Date: Wed, 17 May 2006 17:55:45 +0000 (+0000) Subject: Add an assertion, avoid some unneeded work for each call. No functionality X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=b248e16afd105fd8c01e08d8bf997b08ff08d127;p=oota-llvm.git Add an assertion, avoid some unneeded work for each call. No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@28347 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp index 9f8b999b56b..3799f7cc056 100644 --- a/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp +++ b/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp @@ -820,13 +820,15 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) { case ISD::FORMAL_ARGUMENTS: case ISD::CALL: // The only option for this is to custom lower it. - Result = TLI.LowerOperation(Result.getValue(0), DAG); - assert(Result.Val && "Target didn't custom lower this node!"); + Tmp3 = TLI.LowerOperation(Result.getValue(0), DAG); + assert(Tmp3.Val && "Target didn't custom lower this node!"); + assert(Tmp3.Val->getNumValues() == Result.Val->getNumValues() && + "Lowering call/formal_arguments produced unexpected # results!"); // Since CALL/FORMAL_ARGUMENTS nodes produce multiple values, make sure to // remember that we legalized all of them, so it doesn't get relegalized. - for (unsigned i = 0, e = Result.Val->getNumValues(); i != e; ++i) { - Tmp1 = LegalizeOp(Result.getValue(i)); + for (unsigned i = 0, e = Tmp3.Val->getNumValues(); i != e; ++i) { + Tmp1 = LegalizeOp(Tmp3.getValue(i)); if (Op.ResNo == i) Tmp2 = Tmp1; AddLegalizedOperand(SDOperand(Node, i), Tmp1); @@ -1056,8 +1058,10 @@ SDOperand SelectionDAGLegalize::LegalizeOp(SDOperand Op) { // Merge in the last call, to ensure that this call start after the last // call ended. - Tmp1 = DAG.getNode(ISD::TokenFactor, MVT::Other, Tmp1, LastCALLSEQ_END); - Tmp1 = LegalizeOp(Tmp1); + if (LastCALLSEQ_END.getOpcode() != ISD::EntryNode) { + Tmp1 = DAG.getNode(ISD::TokenFactor, MVT::Other, Tmp1, LastCALLSEQ_END); + Tmp1 = LegalizeOp(Tmp1); + } // Do not try to legalize the target-specific arguments (#1+). if (Tmp1 != Node->getOperand(0)) {