From: Chris Lattner <sabre@nondot.org>
Date: Tue, 29 Dec 2009 07:56:15 +0000 (+0000)
Subject: privatize another interface.
X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=b17f65829c44142827e4c3b9a062ee5cc84f566d;p=oota-llvm.git

privatize another interface.


git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@92255 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/include/llvm/Metadata.h b/include/llvm/Metadata.h
index b7833a6d660..c25ce22511e 100644
--- a/include/llvm/Metadata.h
+++ b/include/llvm/Metadata.h
@@ -221,9 +221,6 @@ public:
   /// getMDKindID - Return a unique non-zero ID for the specified metadata kind.
   unsigned getMDKindID(StringRef Name) const;
 
-  /// isValidName - Return true if Name is a valid custom metadata handler name.
-  static bool isValidName(StringRef Name);
-
   /// getMDKindNames - Populate client supplied SmallVector with the name for
   /// each custom metadata ID.   ID #0 is not used, so it is filled in as empty.
   void getMDKindNames(SmallVectorImpl<StringRef> &) const;
diff --git a/lib/VMCore/Metadata.cpp b/lib/VMCore/Metadata.cpp
index 26987676653..216d8a20af2 100644
--- a/lib/VMCore/Metadata.cpp
+++ b/lib/VMCore/Metadata.cpp
@@ -389,8 +389,9 @@ void MetadataContextImpl::removeAllMetadata(Instruction *Inst) {
 MetadataContext::MetadataContext() : pImpl(new MetadataContextImpl()) { }
 MetadataContext::~MetadataContext() { delete pImpl; }
 
+#ifndef NDEBUG
 /// isValidName - Return true if Name is a valid custom metadata handler name.
-bool MetadataContext::isValidName(StringRef MDName) {
+static bool isValidName(StringRef MDName) {
   if (MDName.empty())
     return false;
 
@@ -404,9 +405,11 @@ bool MetadataContext::isValidName(StringRef MDName) {
   }
   return true;
 }
+#endif
 
 /// getMDKindID - Return a unique non-zero ID for the specified metadata kind.
 unsigned MetadataContext::getMDKindID(StringRef Name) const {
+  assert(isValidName(Name) && "Invalid MDNode name");
   return pImpl->getMDKindID(Name);
 }