From: David Majnemer Date: Thu, 20 Mar 2014 06:28:55 +0000 (+0000) Subject: Object: Abstract out the determination of function line symbols X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=b000c172ed6f23fad76d2e96dd16ff0e0bc799ae;p=oota-llvm.git Object: Abstract out the determination of function line symbols No functionality change. git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@204313 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Object/COFF.h b/include/llvm/Object/COFF.h index 0f24c1b8e51..31b7d6ea174 100644 --- a/include/llvm/Object/COFF.h +++ b/include/llvm/Object/COFF.h @@ -210,6 +210,10 @@ struct coff_symbol { !COFF::isReservedSectionNumber(SectionNumber); } + bool isFunctionLineInfo() const { + return StorageClass == COFF::IMAGE_SYM_CLASS_FUNCTION; + } + bool isWeakExternal() const { return StorageClass == COFF::IMAGE_SYM_CLASS_WEAK_EXTERNAL || (StorageClass == COFF::IMAGE_SYM_CLASS_EXTERNAL && diff --git a/tools/obj2yaml/coff2yaml.cpp b/tools/obj2yaml/coff2yaml.cpp index b003029407c..1542506e5f9 100644 --- a/tools/obj2yaml/coff2yaml.cpp +++ b/tools/obj2yaml/coff2yaml.cpp @@ -157,7 +157,7 @@ void COFFDumper::dumpSymbols(unsigned NumSymbols) { reinterpret_cast( AuxData.data()); dumpFunctionDefinition(&Sym, ObjFD); - } else if (Symbol->StorageClass == COFF::IMAGE_SYM_CLASS_FUNCTION) { + } else if (Symbol->isFunctionLineInfo()) { // This symbol describes function line number information. assert(Symbol->NumberOfAuxSymbols == 1 && "Exepected a single aux symbol to describe this section!");