From: Devang Patel Date: Tue, 22 Jun 2010 01:19:38 +0000 (+0000) Subject: Use single interface, using twine, to get named metadata. X-Git-Url: http://plrg.eecs.uci.edu/git/?a=commitdiff_plain;h=a762b093107ac3aa438815627006425d0b13a236;p=oota-llvm.git Use single interface, using twine, to get named metadata. getNamedMetadata(). git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@106518 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/llvm/Module.h b/include/llvm/Module.h index 15e0a17e1e5..994184f7565 100644 --- a/include/llvm/Module.h +++ b/include/llvm/Module.h @@ -325,8 +325,7 @@ public: /// getNamedMetadata - Return the first NamedMDNode in the module with the /// specified name. This method returns null if a NamedMDNode with the /// specified name is not found. - NamedMDNode *getNamedMetadata(StringRef Name) const; - NamedMDNode *getNamedMetadataUsingTwine(Twine Name) const; + NamedMDNode *getNamedMetadata(const Twine &Name) const; /// getOrInsertNamedMetadata - Return the first named MDNode in the module /// with the specified name. This method returns a new NamedMDNode if a diff --git a/lib/Analysis/DebugInfo.cpp b/lib/Analysis/DebugInfo.cpp index fe19ff8dbdb..feb7a303d0e 100644 --- a/lib/Analysis/DebugInfo.cpp +++ b/lib/Analysis/DebugInfo.cpp @@ -1062,8 +1062,7 @@ DIVariable DIFactory::CreateVariable(unsigned Tag, DIDescriptor Context, char One = '\1'; if (FName.startswith(StringRef(&One, 1))) FName = FName.substr(1); - NamedMDNode *FnLocals = - M.getNamedMetadataUsingTwine(Twine("llvm.dbg.lv.", FName)); + NamedMDNode *FnLocals = M.getNamedMetadata(Twine("llvm.dbg.lv.", FName)); if (!FnLocals) FnLocals = NamedMDNode::Create(VMContext, Twine("llvm.dbg.lv.", FName), NULL, 0, &M); diff --git a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp index d47359c02b1..89993ae9fd4 100644 --- a/lib/CodeGen/AsmPrinter/DwarfDebug.cpp +++ b/lib/CodeGen/AsmPrinter/DwarfDebug.cpp @@ -2260,8 +2260,8 @@ void DwarfDebug::collectVariableInfo(const MachineFunction *MF) { const Function *F = MF->getFunction(); const Module *M = F->getParent(); if (NamedMDNode *NMD = - M->getNamedMetadataUsingTwine(Twine("llvm.dbg.lv.", - getRealLinkageName(F->getName())))) { + M->getNamedMetadata(Twine("llvm.dbg.lv.", + getRealLinkageName(F->getName())))) { for (unsigned i = 0, e = NMD->getNumOperands(); i != e; ++i) { DIVariable DV(cast_or_null(NMD->getOperand(i))); if (!DV || !Processed.insert(DV)) diff --git a/lib/VMCore/Module.cpp b/lib/VMCore/Module.cpp index a06911f77ad..38a51dfd5d3 100644 --- a/lib/VMCore/Module.cpp +++ b/lib/VMCore/Module.cpp @@ -313,11 +313,7 @@ GlobalAlias *Module::getNamedAlias(StringRef Name) const { /// getNamedMetadata - Return the first NamedMDNode in the module with the /// specified name. This method returns null if a NamedMDNode with the /// specified name is not found. -NamedMDNode *Module::getNamedMetadata(StringRef Name) const { - return NamedMDSymTab->lookup(Name); -} - -NamedMDNode *Module::getNamedMetadataUsingTwine(Twine Name) const { +NamedMDNode *Module::getNamedMetadata(const Twine &Name) const { SmallString<256> NameData; StringRef NameRef = Name.toStringRef(NameData); return NamedMDSymTab->lookup(NameRef);